You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/19 04:47:35 UTC
[PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
rusackas opened a new pull request, #41218:
URL: https://github.com/apache/superset/pull/41218
### SUMMARY
When viewing an embedded dashboard as a guest user, clicking a table column header to sort raises `Guest user cannot modify chart payload`. This is a false positive from the `query_context_modified()` guard in `superset/security/manager.py`.
**Root cause:** `orderby` was compared with the same strict subset check as `metrics`, `columns`, and `groupby` — the requested `orderby` had to be a subset of the stored chart's `orderby`. Saved charts almost always store `orderby == []`, so any guest sort (e.g. `[["gender", true]]`) fails the subset check and the request is rejected, even though sorting only changes the **ordering** of the result, not which data is read.
**Fix:** `orderby` is now validated separately. A guest may sort by any column or metric the stored chart already references (collected from the chart's `params_dict` and stored `query_context` — columns, groupby, metrics, all_columns, plus existing order-by targets). Any order-by term **not** present in the stored chart — e.g. a free-form `random()` expression — is still rejected, so the existing SQL-injection protection is preserved.
While here, the columns/metrics/groupby comparison is extracted into a small helper (`_columns_metrics_modified`) to keep `query_context_modified` within the complexity budget, and a pre-existing variable-shadowing bug in the inner loop (`for key in equivalent` shadowing the outer `key`) is fixed.
> ⚠️ **Security-sensitive area — please review carefully.** This relaxes the guest payload-tampering guard. The intent is to permit legitimate re-ordering while continuing to reject any order-by term the chart does not already expose. The existing injection test (`test_query_context_modified_orderby`, sorting by `random()`) still passes. cc anyone who worked on the recent `_native_filter_*` hardening in this module — the new check mirrors that `_native_filter_term_allowed` style.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** Guest clicks a table column header → `Data error: Guest user cannot modify chart payload`.
**After:** Guest can sort embedded table columns. Sorting by an expression not present in the chart (e.g. `random()`) is still blocked.
### TESTING INSTRUCTIONS
```bash
pytest tests/unit_tests/security/manager_test.py -k "query_context_modified" -v
```
New tests (added alongside the existing `test_query_context_modified_orderby` injection test, which continues to pass):
- `test_query_context_modified_orderby_sort_by_column` — sort by an existing column → allowed
- `test_query_context_modified_orderby_sort_by_metric` — sort by an existing metric → allowed
- `test_query_context_modified_orderby_sort_by_adhoc_metric` — sort by an existing adhoc metric definition → allowed
- `test_query_context_modified_orderby_unknown_column` — sort by a column not in the chart → rejected
- `test_query_context_modified_orderby_empty` — empty order-by → allowed
Manual: open an embedded dashboard with a table chart as a guest user and click a column header to sort — it should reorder instead of erroring.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #41218:
URL: https://github.com/apache/superset/pull/41218#discussion_r3440546214
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
Review Comment:
These are tiny local closures inside an already-documented helper — a docstring on each feels like noise, so leaving them as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41218:
URL: https://github.com/apache/superset/pull/41218#discussion_r3440313434
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
Review Comment:
**Suggestion:** Add a short docstring to this newly introduced helper function so the intent and expected input shape are documented inline. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly introduced Python function in a changed hunk, and it does not
include a docstring. The custom rule requires new Python functions and classes
to be documented inline, so the suggestion correctly identifies a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6c5da182ed2f4c4b80c5014604738ecd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6c5da182ed2f4c4b80c5014604738ecd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 540:542
**Comment:**
*Custom Rule: Add a short docstring to this newly introduced helper function so the intent and expected input shape are documented inline.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=218d9e87f1f2894777c20c2ecabe5d2e2722d6dbc43eaf1d33b517dc00967188&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=218d9e87f1f2894777c20c2ecabe5d2e2722d6dbc43eaf1d33b517dc00967188&reaction=dislike'>👎</a>
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
- if form_data is None:
- return False
+ def add_orderby(entries: Any) -> None:
+ for entry in entries or []:
+ if isinstance(entry, (list, tuple)) and entry:
+ allowed.add(freeze_value(entry[0]))
Review Comment:
**Suggestion:** Add a concise docstring to this new helper function to describe how order-by entries are interpreted and collected. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This helper function was newly added in the PR and has no docstring. Since the
rule requires newly added Python functions and classes to include docstrings,
this is a real rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5aa79b6879204bf1a421bd7def0f2d5e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5aa79b6879204bf1a421bd7def0f2d5e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 544:547
**Comment:**
*Custom Rule: Add a concise docstring to this new helper function to describe how order-by entries are interpreted and collected.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=b4c4f0f53fce9a8cc2081786996f88f4857c59513b0084de43c3800c984a4598&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=b4c4f0f53fce9a8cc2081786996f88f4857c59513b0084de43c3800c984a4598&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41218:
URL: https://github.com/apache/superset/pull/41218#discussion_r3440344055
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
- if form_data is None:
- return False
+ def add_orderby(entries: Any) -> None:
+ for entry in entries or []:
+ if isinstance(entry, (list, tuple)) and entry:
+ allowed.add(freeze_value(entry[0]))
- # cannot request a different chart
- if form_data.get("slice_id") != stored_chart.id:
- return True
+ params = stored_chart.params_dict
+ for key in ("columns", "groupby", "metrics", "all_columns"):
+ add(params.get(key))
+ add_orderby(params.get("orderby"))
- stored_query_context = (
- json.loads(cast(str, stored_chart.query_context))
- if stored_chart.query_context
- else None
- )
+ if stored_query_context:
+ for query in stored_query_context.get("queries") or []:
+ for key in ("columns", "groupby", "metrics"):
+ add(query.get(key))
+ add_orderby(query.get("orderby"))
+
+ return allowed
- # compare columns and metrics in form_data with stored values
+
+def _orderby_modified(
+ query_context: "QueryContext",
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> bool:
+ """
+ Whether any order-by clause sorts by a term the stored chart does not already
+ reference.
+
+ A guest reordering an embedded chart by one of its existing columns or
+ metrics is legitimate and must not read as tampering; introducing a new
+ expression is not, and is rejected.
+ """
+ allowed = _collect_sortable_identifiers(stored_chart, stored_query_context)
+ form_data = query_context.form_data or {}
+ requested = list(form_data.get("orderby") or [])
+ for query in query_context.queries:
+ requested.extend(getattr(query, "orderby", None) or [])
+
+ for entry in requested:
+ term = entry[0] if isinstance(entry, (list, tuple)) and entry else entry
+ if freeze_value(term) not in allowed:
+ return True
Review Comment:
**Suggestion:** The new order-by check validates only the first element of each entry but never validates the entry shape. A malformed payload like `orderby=["gender"]` or `orderby=[["gender"]]` can pass this guard (because the term is allowed) and then fail later when query code unpacks each order-by item as `(column, ascending)`, causing a runtime error for guest requests. Reject order-by entries unless they are exactly two-item list/tuple pairs with a boolean direction. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Malformed orderby can crash chart compile/query execution.
- ❌ Guest payload guard fails to reject structurally invalid input.
- ⚠️ Embedded/ChartData callers can trigger unexpected 500 errors.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Trigger chart compilation via `_compile_chart` in
`superset/mcp_service/chart/compile.py:44-55` with a form_data payload containing a
malformed order-by clause, e.g. `form_data["orderby"] = ["gender"]` and a valid
metric/column `"gender"` on the chosen dataset.
2. `_compile_chart` builds a `QueryContext` by calling `QueryContextFactory().create(...)`
and passes `queries=[{"columns": columns, "metrics": metrics, "orderby":
form_data.get("orderby", []), ...}]` (compile.py:42-55) so the malformed `["gender"]` list
becomes the `orderby` field for the first `QueryObject`.
3. `ChartDataCommand.validate()` in
`superset/commands/chart/data/get_data_command.py:72-73` calls
`QueryContext.raise_for_access()`, which delegates to
`security_manager.raise_for_access(..., query_context=query_context)`; in
`SupersetSecurityManager.raise_for_access` (`superset/security/manager.py:3436-3450`)
guest users invoke `query_context_modified(query_context)`, which calls
`_orderby_modified` (`superset/security/manager.py:84-107`). Inside `_orderby_modified`,
the loop at lines 582‑585 iterates `entry = "gender"`, computes `term = entry` (not a
list/tuple), finds `freeze_value(term)` in the allowed set from
`_collect_sortable_identifiers`, and therefore does not flag the malformed shape as
tampering.
4. `ChartDataCommand.run()` then executes the query via `QueryContext.get_payload` →
`QueryContextProcessor.get_df_payload`
(`superset/common/query_context_processor.py:82-90`) → datasource query building, which
ultimately reaches `superset/models/helpers.py:3170-3172` where `for orig_col, ascending
in orderby:` attempts to unpack each `orderby` element. Because `orderby` contains a bare
string `"gender"` instead of `(column, bool)`, Python raises a `ValueError` during
unpacking, causing a 500 error for this request instead of being rejected early as an
invalid/tampered guest payload.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=83c77c93a5d940e3868c710ba5b07c4f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=83c77c93a5d940e3868c710ba5b07c4f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 582:585
**Comment:**
*Api Mismatch: The new order-by check validates only the first element of each entry but never validates the entry shape. A malformed payload like `orderby=["gender"]` or `orderby=[["gender"]]` can pass this guard (because the term is allowed) and then fail later when query code unpacks each order-by item as `(column, ascending)`, causing a runtime error for guest requests. Reject order-by entries unless they are exactly two-item list/tuple pairs with a boolean direction.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=0976d53aaaa81935ccfc712039aba97b9b6d9ebbb43bc7e5098e242d2e877adf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=0976d53aaaa81935ccfc712039aba97b9b6d9ebbb43bc7e5098e242d2e877adf&reaction=dislike'>👎</a>
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
- if form_data is None:
- return False
+ def add_orderby(entries: Any) -> None:
+ for entry in entries or []:
+ if isinstance(entry, (list, tuple)) and entry:
+ allowed.add(freeze_value(entry[0]))
- # cannot request a different chart
- if form_data.get("slice_id") != stored_chart.id:
- return True
+ params = stored_chart.params_dict
+ for key in ("columns", "groupby", "metrics", "all_columns"):
+ add(params.get(key))
Review Comment:
**Suggestion:** Sortable identifiers are collected from `columns/groupby/metrics/all_columns` only, but many legacy chart payloads store a single metric under `metric` (singular). For charts without stored `query_context`, this misses the chart's actual metric and wrongly flags legitimate guest sorts by that metric as tampering. Include legacy singular metric fields when building the allowed sort target set. [incomplete implementation]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Embedded guests blocked on legacy metric-based charts.
- ⚠️ Legitimate metric sorts misclassified as payload tampering.
- ⚠️ Inconsistent behavior between legacy and modern chart configs.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Consider a legacy Big Number-style chart whose saved form_data (stored on the `Slice`)
uses the singular `"metric"` field instead of the newer `"metrics"` list; this legacy
behavior is documented in `_compile_chart` in
`superset/mcp_service/chart/compile.py:33-36`, which explicitly treats
`form_data["metric"]` as the metric when `metrics` is empty.
2. When this chart is embedded and loaded as a guest, the backend reconstructs a
`QueryContext` (via `QueryContextFactory.create`,
`superset/common/query_context_factory.py:88-19`), and
`query_context_modified(query_context)` in `superset/security/manager.py:152-195` is
invoked from `SupersetSecurityManager.raise_for_access` (`security/manager.py:3436-3450`)
to enforce guest payload integrity.
3. Inside `query_context_modified`, `_collect_sortable_identifiers(stored_chart,
stored_query_context)` is called (`security/manager.py:44-81`). For charts without a
stored `query_context` JSON, `stored_query_context` is `None`, so the allowed set is built
only from `stored_chart.params_dict`. The loop at lines 550‑551 iterates keys `("columns",
"groupby", "metrics", "all_columns")` and never reads `params_dict["metric"]`, so the
chart's actual legacy metric is omitted from the `allowed` sort identifiers.
4. If the chart's query uses that metric in `orderby` (for example, Big Number's
`sort_by_metric` logic sets `query_obj["orderby"] = [(query_obj["metrics"][0], False)]` in
`superset/viz.py:1277-1279`), then `_orderby_modified` (`security/manager.py:84-107`) will
see each order-by term's `freeze_value(term)` not present in the `allowed` set and return
`True`. This causes `query_context_modified` to return `True` and
`SupersetSecurityManager.raise_for_access` to raise a `SupersetSecurityException` with
message "Guest user cannot modify chart payload" (`security/manager.py:3436-3450`),
wrongly blocking legitimate guest views/sorts on such legacy charts.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e4cb6dfef3e04ef8a46b74e4e9088684&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e4cb6dfef3e04ef8a46b74e4e9088684&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 550:551
**Comment:**
*Incomplete Implementation: Sortable identifiers are collected from `columns/groupby/metrics/all_columns` only, but many legacy chart payloads store a single metric under `metric` (singular). For charts without stored `query_context`, this misses the chart's actual metric and wrongly flags legitimate guest sorts by that metric as tampering. Include legacy singular metric fields when building the allowed sort target set.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=912bde1944837a6c7753a34c3c7238f66b708c0a69f8e9623cc59748f360b408&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41218&comment_hash=912bde1944837a6c7753a34c3c7238f66b708c0a69f8e9623cc59748f360b408&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4748586951
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41218?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `8.51064%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.64%. Comparing base ([`79cfe4d`](https://app.codecov.io/gh/apache/superset/commit/79cfe4d9bcd688b76ca453ed9bf38f2738a982ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`27c481d`](https://app.codecov.io/gh/apache/superset/commit/27c481d75d989a8b36cfc5b87e1425a7e7b3066b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/41218?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/41218?src=pr&el=tree&filepath=superset%2Fsecurity%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | 8.51% | [43 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (79cfe4d) and HEAD (27c481d). Click for more details.
>
> <details><summary>HEAD has 45 uploads less than BASE</summary>
>
>| Flag | BASE (79cfe4d) | HEAD (27c481d) |
>|------|------|------|
>|python|37|2|
>|presto|6|1|
>|hive|6|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41218 +/- ##
==========================================
- Coverage 64.36% 55.64% -8.72%
==========================================
Files 2651 2651
Lines 144812 144848 +36
Branches 33417 33429 +12
==========================================
- Hits 93208 80605 -12603
- Misses 49935 63509 +13574
+ Partials 1669 734 -935
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.30% <8.51%> (-0.02%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.89% <8.51%> (-0.02%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.95% <8.51%> (-18.62%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41218?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4779388146
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | be0d9bc9e3fd4e55cbbafa51eb333b575f062a5e |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a3a8153c8a38a0008319e8e |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41218--superset-docs-preview.netlify.app](https://deploy-preview-41218--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAgEADQu8w6SZFi6gYdY3SmD1SKGhTR3XP3Fu-FmMIRC4wADbhEp1-r5-1ul0tyUXI4YRZWhdwuKodUamSJe3gmrrUnS2g665EsktYarRkEBb4f) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41218--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4748571846
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #41218:
URL: https://github.com/apache/superset/pull/41218#discussion_r3440546886
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
- if form_data is None:
- return False
+ def add_orderby(entries: Any) -> None:
+ for entry in entries or []:
+ if isinstance(entry, (list, tuple)) and entry:
+ allowed.add(freeze_value(entry[0]))
- # cannot request a different chart
- if form_data.get("slice_id") != stored_chart.id:
- return True
+ params = stored_chart.params_dict
+ for key in ("columns", "groupby", "metrics", "all_columns"):
+ add(params.get(key))
Review Comment:
Good catch on the legacy singular `metric` — added it to the allowed sort targets and a test for it.
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
- if form_data is None:
- return False
+ def add_orderby(entries: Any) -> None:
+ for entry in entries or []:
+ if isinstance(entry, (list, tuple)) and entry:
+ allowed.add(freeze_value(entry[0]))
- # cannot request a different chart
- if form_data.get("slice_id") != stored_chart.id:
- return True
+ params = stored_chart.params_dict
+ for key in ("columns", "groupby", "metrics", "all_columns"):
+ add(params.get(key))
+ add_orderby(params.get("orderby"))
- stored_query_context = (
- json.loads(cast(str, stored_chart.query_context))
- if stored_chart.query_context
- else None
- )
+ if stored_query_context:
+ for query in stored_query_context.get("queries") or []:
+ for key in ("columns", "groupby", "metrics"):
+ add(query.get(key))
+ add_orderby(query.get("orderby"))
+
+ return allowed
- # compare columns and metrics in form_data with stored values
+
+def _orderby_modified(
+ query_context: "QueryContext",
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> bool:
+ """
+ Whether any order-by clause sorts by a term the stored chart does not already
+ reference.
+
+ A guest reordering an embedded chart by one of its existing columns or
+ metrics is legitimate and must not read as tampering; introducing a new
+ expression is not, and is rejected.
+ """
+ allowed = _collect_sortable_identifiers(stored_chart, stored_query_context)
+ form_data = query_context.form_data or {}
+ requested = list(form_data.get("orderby") or [])
+ for query in query_context.queries:
+ requested.extend(getattr(query, "orderby", None) or [])
+
+ for entry in requested:
+ term = entry[0] if isinstance(entry, (list, tuple)) and entry else entry
+ if freeze_value(term) not in allowed:
+ return True
Review Comment:
Fair — order-by entries now have to be `(term, bool)` pairs or they read as tampering, so a bare/nested shape gets rejected before it can blow up query building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4750184050
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4781000987
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #41218:
URL: https://github.com/apache/superset/pull/41218#discussion_r3440546214
##########
superset/security/manager.py:
##########
@@ -520,42 +520,87 @@ def _native_filter_request_modified(query_context: "QueryContext") -> bool:
)
-def query_context_modified(query_context: "QueryContext") -> bool:
+def _collect_sortable_identifiers(
+ stored_chart: "Slice",
+ stored_query_context: Optional[dict[str, Any]],
+) -> set[str]:
"""
- Check if a query context has been modified.
-
- This is used to ensure guest users don't modify the payload and fetch data
- different from what was shared with them in dashboards.
+ Frozen column names and metric labels/definitions a guest may legitimately
+ sort by: every column or metric the stored chart already references.
+
+ Order-by only changes the ordering of the result, not which data is read, so
+ any column or metric already part of the chart is a safe sort target. A term
+ that is not present in the stored chart (for example a free-form ``random()``
+ expression) cannot be validated and must be rejected. Order-by entries are
+ ``(column_or_metric, ascending)`` pairs, so only their first element is
+ collected.
"""
- form_data = query_context.form_data
- stored_chart = query_context.slice_
+ allowed: set[str] = set()
- # Native-filter data requests have no associated chart (no slice_id). Rather
- # than accepting any payload, constrain them to the column(s) the dashboard's
- # native filter is allowed to target; other chartless paths keep prior
- # behavior (see _native_filter_request_modified).
- if stored_chart is None:
- return _native_filter_request_modified(query_context)
+ def add(values: Any) -> None:
+ for value in values or []:
+ allowed.add(freeze_value(value))
Review Comment:
These are tiny local closures inside an already-documented helper — a docstring on each feels like noise, so leaving them as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41218:
URL: https://github.com/apache/superset/pull/41218#issuecomment-4779373636
@aminghadersohi good catches — pushed a fix:
- MEDIUM #1: added `all_columns` to the stored-query-context loop in `_collect_sortable_identifiers`, with a regression test that goes red without it.
- MEDIUM #2: that test exercises the stored-qc branch in isolation (column present only in the query context, not `params_dict`).
- LOW #3 / NIT #4: added the explanatory comments on the order-by union and the intentional `stored_values` asymmetry.
Left the direction-bit and closure-docstring calls as-is per the earlier reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): allow guest users to sort table columns in embedded dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #41218:
URL: https://github.com/apache/superset/pull/41218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org