You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/07 12:20:59 UTC
[GitHub] [hadoop-ozone] elek commented on a change in pull request #1401: HDDS-3927. Rename HDFS_OM_OPTS/HDDS_DN_OPTS to OZONE_MANAGER_OPTS/OZONE_DATANODE_OPTS
elek commented on a change in pull request #1401:
URL: https://github.com/apache/hadoop-ozone/pull/1401#discussion_r484396435
##########
File path: hadoop-hdds/common/src/main/conf/hadoop-env.sh
##########
@@ -400,7 +400,16 @@ export HADOOP_OS_TYPE=${HADOOP_OS_TYPE:-$(uname -s)}
# These options will be appended to the options specified as HADOOP_OPTS
# and therefore may override any similar flags set in HADOOP_OPTS
#
-# export HDFS_OM_OPTS=""
+# export OZONE_MANAGER_OPTS=""
Review comment:
I think `OZONE_OM_OPTS` is aligned with the naming conventions. Especially as it's already working thanks to the
```
hadoop_subcommand_opts "${HADOOP_SHELL_EXECNAME}" "${HADOOP_SUBCMD}"
```
line.
##########
File path: hadoop-ozone/dist/src/shell/ozone/ozone
##########
@@ -105,8 +105,9 @@ function ozonecmd_case
# Corresponding Ratis issue https://issues.apache.org/jira/browse/RATIS-534.
# TODO: Fix the problem related to netty resource leak detector throwing
# exception as mentioned in HDDS-3812
- HDDS_DN_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false -Dorg.apache.ratis.thirdparty.io.netty.leakDetection.level=disabled -Dlog4j.configurationFile=${HADOOP_CONF_DIR}/dn-audit-log4j2.properties ${HDDS_DN_OPTS}"
- HADOOP_OPTS="${HADOOP_OPTS} ${HDDS_DN_OPTS}"
+ hadoop_deprecate_envvar HDDS_DN_OPTS OZONE_DATANODE_OPTS
+ OZONE_DATANODE_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false -Dorg.apache.ratis.thirdparty.io.netty.leakDetection.level=disabled -Dlog4j.configurationFile=${HADOOP_CONF_DIR}/dn-audit-log4j2.properties ${OZONE_DATANODE_OPTS}"
+ HADOOP_OPTS="${HADOOP_OPTS} ${OZONE_DATANODE_OPTS}"
Review comment:
I think this line is not necessary, because it will be added by
```
hadoop_subcommand_opts "${HADOOP_SHELL_EXECNAME}" "${HADOOP_SUBCMD}"
```
But please check it.
##########
File path: hadoop-ozone/dist/src/shell/ozone/ozone
##########
@@ -154,8 +155,9 @@ function ozonecmd_case
om)
HADOOP_SUBCMD_SUPPORTDAEMONIZATION="true"
HADOOP_CLASSNAME=org.apache.hadoop.ozone.om.OzoneManagerStarter
- HDFS_OM_OPTS="${HDFS_OM_OPTS} -Dlog4j.configurationFile=${HADOOP_CONF_DIR}/om-audit-log4j2.properties"
- HADOOP_OPTS="${HADOOP_OPTS} ${HDFS_OM_OPTS}"
+ hadoop_deprecate_envvar HDFS_OM_OPTS OZONE_MANAGER_OPTS
+ OZONE_MANAGER_OPTS="${OZONE_MANAGER_OPTS} -Dlog4j.configurationFile=${HADOOP_CONF_DIR}/om-audit-log4j2.properties"
+ HADOOP_OPTS="${HADOOP_OPTS} ${OZONE_MANAGER_OPTS}"
Review comment:
Same as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org