You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/13 11:03:25 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #10432: [Improvement][Metrics] Change metrics name following naming convention
EricGao888 opened a new issue, #10432:
URL: https://github.com/apache/dolphinscheduler/issues/10432
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Inconsistent naming will cause portability and compatibility issues, as well as, make users confused when the number of metrics gets large. Therefore, we need to:
* Establish the naming convention for DS metrics.
* Change the current metrics names following the convention.
We could refer to official docs [micrometers metrics naming convention](https://github.com/micrometer-metrics/micrometer-docs/blob/main/src/docs/concepts/naming.adoc#:~:text=Micrometer%20employs%20a%20naming%20convention,between%20one%20system%20and%20another.) for details.
* One possible approach and example could be found [here](https://docs.qq.com/doc/DTGFiSkRIbHBIeVp3) in `naming convention section`.
### Use case
_No response_
### Related issues
releated: #9324
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10432: [Improvement][Metrics] Change metrics name following naming convention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10432:
URL: https://github.com/apache/dolphinscheduler/issues/10432#issuecomment-1153777968
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed issue #10432: [Improvement][Metrics] Apply micrometer naming convention to metrics
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed issue #10432: [Improvement][Metrics] Apply micrometer naming convention to metrics
URL: https://github.com/apache/dolphinscheduler/issues/10432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org