You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/08/26 00:52:57 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #33754: Improve modules import in Airflow providers by some of them into a type-checking block
hussein-awala opened a new pull request, #33754:
URL: https://github.com/apache/airflow/pull/33754
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694386247
I created:
- https://github.com/apache/airflow/pull/33780 for amazon provider
- https://github.com/apache/airflow/pull/33781 for kubernetes provider
- https://github.com/apache/airflow/pull/33783 for google provider
and I kept this one for the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694200556
I wish we had other mechanism for that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694717051
Providers are safe to merge since we do not cherry-pick them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694216088
I will add some pre-commits after merging the different PRs. I already prepared some of them including this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694225057
> I will add some pre-commits after merging the different PRs. I already prepared some of them including this one.
I figured you are not doing it manually :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694333165
I will try to split it in smaller PRs starting with the bigger providers (k8S, AWS, GCP, ...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33754:
URL: https://github.com/apache/airflow/pull/33754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33754: Improve modules import in Airflow providers by some of them into a type-checking block
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33754:
URL: https://github.com/apache/airflow/pull/33754#issuecomment-1694201750
BTW. This calls for automation and pre-commit. I think we should ba able to have an AST pre-commit to verify if an import is only used in Type Hints (and ask to move them to `if TYPE_CHECKING`) - and the other way round - we could check if anything that is in `TYPE_CHECKING` is actually only used for type hints (cc: @uranusjr ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org