You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Zdenek Sochor (JIRA)" <de...@myfaces.apache.org> on 2007/10/17 15:28:52 UTC

[jira] Commented: (TOMAHAWK-1133) Data Scroller doesnt honor dynamic rowclasses during pagination

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535547 ] 

Zdenek Sochor commented on TOMAHAWK-1133:
-----------------------------------------

Hi David,
  this behaviour is NOT a bug.

RowClasses attribute is property of HtmlDataTable, not DataScroller and this is from API doc:
----
getRowClasses

public java.lang.String getRowClasses()

    Return the value of the rowClasses property.

    Contents: Comma-delimited list of CSS style classes that will be applied to the rows of this table. A space separated list of classes may also be specified for any individual row. Thes styles are applied, in turn, to each row in the table. For example, if the list has two elements, the first style class in the list is applied to the first row, the second to the second row, the first to the third row, the second to the fourth row, etc. In other words, we keep iterating through the list until we reach the end, and then we start at the beginning again. 
----

It means that rowClasses are relative to top of rendered table, not relative to start of data, your asked behaviour is something against ways of RI.

IF you want your behavior in rendering, you have to rework your dynamic styles list generation.
You have to shift elements by (first % size), 
where first is index of first row in resulting table (you can get it by valueBinding first attribute of datatable) 
and size is number of elements in your list.
But you must be prepared for performance hit this way.

Best regards,
  Zdenek
  

> Data Scroller doesnt honor dynamic rowclasses during pagination
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-1133
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1133
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>         Environment: Myfaces 1.1.5, Tomahawk 1.1.7snapshot, Tomahawk 1.1.6, Tomcat 6.0
>            Reporter: David Brainard
>
> While using a data scroller with datatable if we specify the rowclasses dynamically(through value binding) only the first page gets the rowclasses assigned properly . When we try to do pagination and go to other page the same rowclasses which were used in the first page repeats i.e the rowclasses doesnt get assigned properly.
> for e.g;  if i have a tag defined like this
>                        <t:dataTable id="myDetailDataTable" var="row"
> 			value="#{testBean.dataList}" columnClasses="#{testBean.styleClass}"
> 			headerClass="headerClass" footerClass="footerClass"
> 			rowClasses="#{testBean.rowClass}" styleClass="dataTable" rows="3" >
> and my rowclass returns something like this
>        public String getRowClass() {
> 		return "rowOdd,rowOdd,rowEven,rowEven,rowEven,rowOdd";
> 	}
> in first page the generated rowclasses are correct which is as follws:
>             
>              1st row:rowOdd, 
>               2st row:rowOdd,
>              3st row: rowEven
> but when i navigate to next page the rowclasses assignment remains the same as first page. 
>             1st row:rowOdd, 
>               2st row:rowOdd,
>              3st row: rowEven
> but it should be as follows:
>              1st row:rowEven, 
>               2st row:rowEven,
>              3st row: rowOdd
>                  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.