[GitHub] [pinot] 61yao commented on a diff in pull request #10219: [multistage] [bugfix] Populate query deadline across the stack

["61yao (via GitHub)" <gi...@apache.org>]

61yao commented on code in PR #10219:
URL: https://github.com/apache/pinot/pull/10219#discussion_r1096222328


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -65,15 +67,16 @@ public QueryDispatcher() {
   public ResultTable submitAndReduce(long requestId, QueryPlan queryPlan,
       MailboxService<TransferableBlock> mailboxService, long timeoutMs, Map<String, String> queryOptions)
       throws Exception {
+    long deadlineNanos = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(timeoutMs);

Review Comment:
   It is actually after plan. It is a good point. I moved the counting of start time to the place where we receive the request. So it is now counting all of the time including parsing and planning.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org