You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/05/07 08:48:43 UTC

[GitHub] [skywalking] wu-sheng edited a comment on issue #2623: Abstract code & Remove redundant code & Simplfy code.

wu-sheng edited a comment on issue #2623: Abstract code & Remove redundant code & Simplfy code.
URL: https://github.com/apache/skywalking/pull/2623#issuecomment-489992613
 
 
   I need to remind you, you should not change the codes, and submit pull request, only based on your code style. SkyWalking is contributed by 120+ contributors, from dozens of companies, all over the world. I am so sure, each one has a different coding style.
   
   If there is a bug and less check invocation, the improvement of PR is good. If just code style, I think we can't accept it, and should not. Because there is no rule we can say which kind of codes is better in worldwide.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services