You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2012/11/26 11:16:58 UTC

[jira] [Created] (OAK-473) Query tck test NodeNameTest fix

Alex Parvulescu created OAK-473:
-----------------------------------

             Summary: Query tck test NodeNameTest fix
                 Key: OAK-473
                 URL: https://issues.apache.org/jira/browse/OAK-473
             Project: Jackrabbit Oak
          Issue Type: Sub-task
          Components: jcr
            Reporter: Alex Parvulescu


Fix for the failing tck test {{NodeNameTest}}, as marked in the oak-jcr pom file.

{code}
NodeName comparison with REFERENCE must fail with InvalidQueryException
{code}

Query:
{code}
select * from [nt:unstructured] AS [s] where (ISCHILDNODE([s], [/testroot])) AND (NAME([s]) = CAST('80e7a0cd-943b-4861-b996-8c3567be2736' AS REFERENCE))
{code}

In Jackrabbit:  {{LuceneQueryFactory#getNodeNameQuery}} throws {{InvalidQueryException("Invalid name value: " + string)}} for any of the following value types: PropertyType.DOUBLE, PropertyType.DECIMAL, PropertyType.LONG, PropertyType.BOOLEAN, PropertyType.REFERENCE, PropertyType.WEAKREFERENCE.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OAK-473) Query tck test NodeNameTest fix

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Mueller reassigned OAK-473:
----------------------------------

    Assignee: Thomas Mueller
    
> Query tck test NodeNameTest fix
> -------------------------------
>
>                 Key: OAK-473
>                 URL: https://issues.apache.org/jira/browse/OAK-473
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>            Reporter: Alex Parvulescu
>            Assignee: Thomas Mueller
>         Attachments: OAK-473.patch
>
>
> Fix for the failing tck test {{NodeNameTest}}, as marked in the oak-jcr pom file.
> {code}
> NodeName comparison with REFERENCE must fail with InvalidQueryException
> {code}
> Query:
> {code}
> select * from [nt:unstructured] AS [s] where (ISCHILDNODE([s], [/testroot])) AND (NAME([s]) = CAST('80e7a0cd-943b-4861-b996-8c3567be2736' AS REFERENCE))
> {code}
> In Jackrabbit:  {{LuceneQueryFactory#getNodeNameQuery}} throws {{InvalidQueryException("Invalid name value: " + string)}} for any of the following value types: PropertyType.DOUBLE, PropertyType.DECIMAL, PropertyType.LONG, PropertyType.BOOLEAN, PropertyType.REFERENCE, PropertyType.WEAKREFERENCE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OAK-473) Query tck test NodeNameTest fix

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504585#comment-13504585 ] 

Thomas Mueller commented on OAK-473:
------------------------------------

I think the "instanceof NodeNameImpl" should be avoided if possible. I will think about an alternative solution, please don't apply the patch just yet.
                
> Query tck test NodeNameTest fix
> -------------------------------
>
>                 Key: OAK-473
>                 URL: https://issues.apache.org/jira/browse/OAK-473
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>            Reporter: Alex Parvulescu
>            Assignee: Thomas Mueller
>         Attachments: OAK-473.patch
>
>
> Fix for the failing tck test {{NodeNameTest}}, as marked in the oak-jcr pom file.
> {code}
> NodeName comparison with REFERENCE must fail with InvalidQueryException
> {code}
> Query:
> {code}
> select * from [nt:unstructured] AS [s] where (ISCHILDNODE([s], [/testroot])) AND (NAME([s]) = CAST('80e7a0cd-943b-4861-b996-8c3567be2736' AS REFERENCE))
> {code}
> In Jackrabbit:  {{LuceneQueryFactory#getNodeNameQuery}} throws {{InvalidQueryException("Invalid name value: " + string)}} for any of the following value types: PropertyType.DOUBLE, PropertyType.DECIMAL, PropertyType.LONG, PropertyType.BOOLEAN, PropertyType.REFERENCE, PropertyType.WEAKREFERENCE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OAK-473) Query tck test NodeNameTest fix

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Mueller resolved OAK-473.
--------------------------------

    Resolution: Fixed

Revision 1416548 (oak-core) and 
revision 1416550 (oak-jcr; enable tests)
                
> Query tck test NodeNameTest fix
> -------------------------------
>
>                 Key: OAK-473
>                 URL: https://issues.apache.org/jira/browse/OAK-473
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>            Reporter: Alex Parvulescu
>            Assignee: Thomas Mueller
>         Attachments: OAK-473.patch
>
>
> Fix for the failing tck test {{NodeNameTest}}, as marked in the oak-jcr pom file.
> {code}
> NodeName comparison with REFERENCE must fail with InvalidQueryException
> {code}
> Query:
> {code}
> select * from [nt:unstructured] AS [s] where (ISCHILDNODE([s], [/testroot])) AND (NAME([s]) = CAST('80e7a0cd-943b-4861-b996-8c3567be2736' AS REFERENCE))
> {code}
> In Jackrabbit:  {{LuceneQueryFactory#getNodeNameQuery}} throws {{InvalidQueryException("Invalid name value: " + string)}} for any of the following value types: PropertyType.DOUBLE, PropertyType.DECIMAL, PropertyType.LONG, PropertyType.BOOLEAN, PropertyType.REFERENCE, PropertyType.WEAKREFERENCE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OAK-473) Query tck test NodeNameTest fix

Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu updated OAK-473:
--------------------------------

    Attachment: OAK-473.patch

attaching proposed patch.

A better place for the verification would have probably been the {{SQL2Parser}} but the {{currentValue()}} method  is not visible there.
                
> Query tck test NodeNameTest fix
> -------------------------------
>
>                 Key: OAK-473
>                 URL: https://issues.apache.org/jira/browse/OAK-473
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>            Reporter: Alex Parvulescu
>         Attachments: OAK-473.patch
>
>
> Fix for the failing tck test {{NodeNameTest}}, as marked in the oak-jcr pom file.
> {code}
> NodeName comparison with REFERENCE must fail with InvalidQueryException
> {code}
> Query:
> {code}
> select * from [nt:unstructured] AS [s] where (ISCHILDNODE([s], [/testroot])) AND (NAME([s]) = CAST('80e7a0cd-943b-4861-b996-8c3567be2736' AS REFERENCE))
> {code}
> In Jackrabbit:  {{LuceneQueryFactory#getNodeNameQuery}} throws {{InvalidQueryException("Invalid name value: " + string)}} for any of the following value types: PropertyType.DOUBLE, PropertyType.DECIMAL, PropertyType.LONG, PropertyType.BOOLEAN, PropertyType.REFERENCE, PropertyType.WEAKREFERENCE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira