You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/12/21 12:13:47 UTC
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/3754
SPARK-4910 [CORE] build failed (use of FileStatus.isFile in Hadoop 1.x)
Fix small Hadoop 1 compile error from SPARK-2261. In Hadoop 1.x, all we have is FileStatus.isFile, so these "is directory" assertions are changed to "is not a file". This is how similar checks are done so far in the code base.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-4910
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3754
----
commit 52c5e4eb73056a99c5c7f938748b08d8572b2b00
Author: Sean Owen <so...@cloudera.com>
Date: 2014-12-21T11:12:09Z
Fix small Hadoop 1 compile error from SPARK-2261
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67785054
According to [HADOOP-6585](https://issues.apache.org/jira/browse/HADOOP-6585), the old behavior / usage was that `!isDir` implies `isFile`. Symlinks broke this, but we don't use them in these tests.
I'm going to merge this into `master` and `branch-1.2` to fix the Hadoop 1 builds. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67783119
@JoshRosen Yes I agree, `isDir` is not quite the same as `!isFile` but it's the closest thing available in 1.x. I'll fix the message above, oops.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67782883
This seems fine to me, especially since this only affects test code. I guess that newer versions of Hadoop have `isSymlink`, so it may not always be the case that `!isDir` implies `isFile`. That said, it looks like this may be the best that we can do in Hadoop 1.x ([see Javadoc](https://hadoop.apache.org/docs/r1.0.4/api/org/apache/hadoop/fs/FileSystem.html#getFileStatus(org.apache.hadoop.fs.Path))), so I'm fine with merging this.
One minor comment, though: it looks like your PR description / commit message describes the opposite of this change:
> In Hadoop 1.x, all we have is FileStatus.isFile, so these "is directory" assertions are changed to "is not a file"
but I think you meant to say
> In Hadoop 1.x, all we have is FileStatus.isDir, so these "is file" assertions are changed to "is not a directory"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67769207
[Test build #24682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24682/consoleFull) for PR 3754 at commit [`52c5e4e`](https://github.com/apache/spark/commit/52c5e4eb73056a99c5c7f938748b08d8572b2b00).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67767146
[Test build #24682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24682/consoleFull) for PR 3754 at commit [`52c5e4e`](https://github.com/apache/spark/commit/52c5e4eb73056a99c5c7f938748b08d8572b2b00).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-4910 [CORE] build failed (use of FileSta...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3754#issuecomment-67769209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24682/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org