[jira] [Commented] (MNG-7569) Plugin descriptor model should contain all elements understood by PluginDescriptorBuilder and correctly specify mandatory attributes

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622223#comment-17622223 ] 

ASF GitHub Bot commented on MNG-7569:
-------------------------------------

kwin opened a new pull request, #842:
URL: https://github.com/apache/maven/pull/842

   Improve descriptions
   Add anchors
   [MNG-7575] Remove deprecated requiresReports
   Relax validation of "configuration" by marking it as "DOM"
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue. Your pull request should address just this issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
          title in the pull request title and in the first line of the commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Plugin descriptor model should contain all elements understood by PluginDescriptorBuilder and correctly specify mandatory attributes
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-7569
>                 URL: https://issues.apache.org/jira/browse/MNG-7569
>             Project: Maven
>          Issue Type: Improvement
>          Components: Plugin API
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>              Labels: plugin-descriptor-1.1
>
> The plugin descriptor schema at https://maven.apache.org/ref/3.8.6/maven-plugin-api/plugin.html currently does not list all elements which are understood by PluginDescriptorBuilder
> * v4Api (Boolean)
> Also none of the elements are currently marked as required but in fact the {{PluginDescriptorBuilder}} unconditionally dereferences some elements. All those should be marked as required in the underlying model (also to generate a proper XSD).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)