[jira] [Commented] (FLINK-9946) Quickstart E2E test archetype version is hard-coded

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565185#comment-16565185 ] 

ASF GitHub Bot commented on FLINK-9946:
---------------------------------------

twalthr commented on a change in pull request #6433: [FLINK-9946][tests] Expose Flink version to E2E tests
URL: https://github.com/apache/flink/pull/6433#discussion_r206849747
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -36,6 +36,8 @@ export EXIT_CODE=0
 
 echo "Flink dist directory: $FLINK_DIR"
 
+FLINK_VERSION=$(cat ${END_TO_END_DIR}/pom.xml | sed -n 's/[[:blank:]]\+<version>\([a-zA-Z0-9\.-]\+\)<\/version>/\1/p')
 
 Review comment:
   It seems that the `+` causes problems. I searched for it but all I could find was:
   https://unix.stackexchange.com/questions/13711/differences-between-sed-on-mac-osx-and-other-standard-sed
   
   Anyway, `sed -n 's/.*<version>\(.*\)<\/version>/\1/p'` runs fine. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Quickstart E2E test archetype version is hard-coded
> ---------------------------------------------------
>
>                 Key: FLINK-9946
>                 URL: https://issues.apache.org/jira/browse/FLINK-9946
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> {code}
> mvn archetype:generate                                   \
>     -DarchetypeGroupId=org.apache.flink                  \
>     -DarchetypeArtifactId=flink-quickstart-${TEST_TYPE}  \
>     -DarchetypeVersion=1.6-SNAPSHOT                      \
>     -DgroupId=org.apache.flink.quickstart                \
>     -DartifactId=${ARTIFACT_ID}                          \
>     -Dversion=${ARTIFACT_VERSION}                        \
>     -Dpackage=org.apache.flink.quickstart                \
>     -DinteractiveMode=false
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)