You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2023/03/29 23:35:32 UTC

[GitHub] [hudi] xushiyan opened a new pull request, #8320: [HUDI-6003] Add schema evolution column nullability test case

xushiyan opened a new pull request, #8320:
URL: https://github.com/apache/hudi/pull/8320

   ### Change Logs
   
   To have complete schema evolution test coverage for release, add a test for alter column nullability.
   
   Also, use conditional annotation to enable/disable test cases based on spark versions.
   - hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3DDL.scala
   - hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestHiveTableSchemaEvolution.java
   
   ### Impact
   
   NA
   
   ### Risk level
   
   NA
   
   ### Documentation Update
   
   NA
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on a diff in pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8320:
URL: https://github.com/apache/hudi/pull/8320#discussion_r1152684673


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3DDL.scala:
##########
@@ -67,110 +70,106 @@ class TestSpark3DDL extends HoodieSparkSqlTestBase {
          |""".stripMargin)
   }
 
-  test("Test multi change data type") {
+  test("Test alter column types") {
     withRecordType()(withTempDir { tmp =>
       Seq("cow", "mor").foreach { tableType =>
         val tableName = generateTableName
         val tablePath = s"${new Path(tmp.getCanonicalPath, tableName).toUri.toString}"
-        if (HoodieSparkUtils.gteqSpark3_1) {

Review Comment:
   do we know why this was enabled only for spark3 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1490015923

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990",
       "triggerID" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15991",
       "triggerID" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990) 
   * 49457f601824a442c4cdd4991ab80f3fab4dbebf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489518176

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489591879

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489914202

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982) 
   * 34065192f37bb41a5d10f54dda2e5582db3d760e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986) 
   * cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489721259

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 7f361ea130553bd66e76bab9e2deff325013095d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980) 
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1490303462

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990",
       "triggerID" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15991",
       "triggerID" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 49457f601824a442c4cdd4991ab80f3fab4dbebf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489828500

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #8320:
URL: https://github.com/apache/hudi/pull/8320#discussion_r1152594066


##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestHiveTableSchemaEvolution.java:
##########
@@ -77,42 +78,38 @@ private void initSparkContexts(String appName) {
   @Test
   public void testCopyOnWriteTableForHive() throws Exception {
     String tableName = "huditest" + new Date().getTime();
-    if (HoodieSparkUtils.gteqSpark3_1()) {
-      sparkSession.sql("set hoodie.schema.on.read.enable=true");
-      String path = new Path(basePath.toAbsolutePath().toString()).toUri().toString();

Review Comment:
   most of the diff are identation. pls hide whitespace to review



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489636645

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978) 
   * 7f361ea130553bd66e76bab9e2deff325013095d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489983996

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990",
       "triggerID" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990) 
   * 49457f601824a442c4cdd4991ab80f3fab4dbebf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489482269

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489521798

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489676567

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978) 
   * 7f361ea130553bd66e76bab9e2deff325013095d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980) 
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489924951

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990",
       "triggerID" : "cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "49457f601824a442c4cdd4991ab80f3fab4dbebf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 34065192f37bb41a5d10f54dda2e5582db3d760e Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986) 
   * cbffc7c54740c34f7dfc13f91d8dc64ccdeb558c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15990) 
   * 49457f601824a442c4cdd4991ab80f3fab4dbebf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489680888

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 7f361ea130553bd66e76bab9e2deff325013095d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980) 
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489640724

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * a60d4e57a556b072690b7aedaa2223ee23383314 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978) 
   * 7f361ea130553bd66e76bab9e2deff325013095d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489846074

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982) 
   * 34065192f37bb41a5d10f54dda2e5582db3d760e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15986) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8320:
URL: https://github.com/apache/hudi/pull/8320#issuecomment-1489837100

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "878d184701616a4acb8372acbab006874caf4aab",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "878d184701616a4acb8372acbab006874caf4aab",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15978",
       "triggerID" : "a60d4e57a556b072690b7aedaa2223ee23383314",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15980",
       "triggerID" : "7f361ea130553bd66e76bab9e2deff325013095d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982",
       "triggerID" : "00d1314ced4bc5c6166e4237916feeb642553ba4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "34065192f37bb41a5d10f54dda2e5582db3d760e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 878d184701616a4acb8372acbab006874caf4aab UNKNOWN
   * 00d1314ced4bc5c6166e4237916feeb642553ba4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15982) 
   * 34065192f37bb41a5d10f54dda2e5582db3d760e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #8320:
URL: https://github.com/apache/hudi/pull/8320#discussion_r1152594066


##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestHiveTableSchemaEvolution.java:
##########
@@ -77,42 +78,38 @@ private void initSparkContexts(String appName) {
   @Test
   public void testCopyOnWriteTableForHive() throws Exception {
     String tableName = "huditest" + new Date().getTime();
-    if (HoodieSparkUtils.gteqSpark3_1()) {
-      sparkSession.sql("set hoodie.schema.on.read.enable=true");
-      String path = new Path(basePath.toAbsolutePath().toString()).toUri().toString();

Review Comment:
   most of the diff are identation. pls hide whitespace to review



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan merged pull request #8320: [HUDI-6003] Add schema evolution column nullability test case

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #8320:
URL: https://github.com/apache/hudi/pull/8320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org