[GitHub] [activemq-nms-amqp] HavretGC commented on a change in pull request #53: AMQNET-634: Use 4 as default msg priority

[GitBox <gi...@apache.org>]

HavretGC commented on a change in pull request #53: AMQNET-634: Use 4 as default msg priority
URL: https://github.com/apache/activemq-nms-amqp/pull/53#discussion_r374542832
 
 

 ##########
 File path: test/Apache-NMS-AMQP-Test/NmsMessageProducerTest.cs
 ##########
 @@ -77,7 +77,7 @@ public void TestGetDisableTimeStamp()
         public void TestPriorityConfiguration()
         {
             IMessageProducer producer = session.CreateProducer(null);
-            Assert.AreEqual(NMSConstants.defaultPriority, producer.Priority);
+            Assert.AreEqual(MsgPriority.BelowNormal, producer.Priority);
 
 Review comment:
   It won't change, I guess. Or at least it shouldn't. It's an enum, that basically represents all available message priorities. I could use int instead but that would require casting. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services