You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "ambaena (via GitHub)" <gi...@apache.org> on 2026/06/04 16:49:28 UTC

[PR] Fix AWS Batch Executor compatibility with Airflow 3 in `try_adopt_task_instances` [airflow]

ambaena opened a new pull request, #68027:
URL: https://github.com/apache/airflow/pull/68027

Related: #62192

The AWS Batch Executor still calls `TaskInstance.command_as_list()` from `try_adopt_task_instances()`. That method is not available in Airflow 3 after the Task SDK changes.

This is triggered when the scheduler restarts or fails over and tries to adopt orphaned task instances that still have an `external_executor_id` pointing to an AWS Batch job. The scheduler calls `adopt_or_reset_orphaned_tasks()`, the Batch executor describes the existing Batch jobs, and then crashes while rebuilding the command for the adopted task instance:

`AttributeError: TaskInstance object has no attribute command_as_list`

The normal submission path already handles Task SDK workloads. This change makes the adoption path use the same Task SDK command serialization on Airflow 3 while keeping the existing `command_as_list()` behavior for Airflow 2.

This mirrors the ECS executor fix from #62192 for the AWS Batch executor.

Testing:
- `prek run --files providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor.py`
- `/Users/ambaena/.local/bin/uv run --project providers/amazon pytest providers/amazon/tests/unit/amazon/aws/executors/batch/test_batch_executor.py -k "try_adopt_task_instances or serialize_workload_to_command or build_task_command" -xvs`

Disclosure: I used an AI assistant to help investigate the failure mode and cross-check the proposed fix. I reviewed the final code and tests myself.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix AWS Batch Executor compatibility with Airflow 3 in `try_adopt_task_instances` [airflow]

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.

o-nikolas merged PR #68027:
URL: https://github.com/apache/airflow/pull/68027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix AWS Batch Executor compatibility with Airflow 3 in `try_adopt_task_instances` [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #68027:
URL: https://github.com/apache/airflow/pull/68027#issuecomment-4624295902

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix AWS Batch Executor compatibility with Airflow 3 in `try_adopt_task_instances` [airflow]

Posted by "ambaena (via GitHub)" <gi...@apache.org>.

ambaena commented on PR #68027:
URL: https://github.com/apache/airflow/pull/68027#issuecomment-4629383469

   Fixed the test failure caused by Python 3.10 compatibility. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix AWS Batch Executor compatibility with Airflow 3 in `try_adopt_task_instances` [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #68027:
URL: https://github.com/apache/airflow/pull/68027#issuecomment-4773378054

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org