[commons-codec] branch master updated: Use Arrays.fill().

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 7ca5b56  Use Arrays.fill().
7ca5b56 is described below

commit 7ca5b56e35c8f518f4826cfad55828e20b626679
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 16:59:38 2020 -0500

    Use Arrays.fill().
---
 src/main/java/org/apache/commons/codec/digest/UnixCrypt.java   |  5 ++---
 .../org/apache/commons/codec/digest/PureJavaCrc32CTest.java    | 10 ++++------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java b/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
index aac0123..7be4958 100644
--- a/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
+++ b/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
@@ -18,6 +18,7 @@ package org.apache.commons.codec.digest;
 
 import java.nio.charset.StandardCharsets;
 import java.security.SecureRandom;
+import java.util.Arrays;
 import java.util.concurrent.ThreadLocalRandom;
 
 /**
@@ -217,9 +218,7 @@ public class UnixCrypt {
         final int eSwap0 = CON_SALT[charZero];
         final int eSwap1 = CON_SALT[charOne] << 4;
         final byte key[] = new byte[8];
-        for (int i = 0; i < key.length; i++) {
-            key[i] = 0;
-        }
+        Arrays.fill(key, (byte) 0);
 
         for (int i = 0; i < key.length && i < original.length; i++) {
             final int iChar = original[i];
diff --git a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java
index 29237b0..87add04 100644
--- a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java
+++ b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.codec.digest;
 
+import java.util.Arrays;
+
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -32,17 +34,13 @@ public class PureJavaCrc32CTest {
 
     @Test
     public void testZeros() {
-        for(int i = 0; i < data.length; i ++) {
-            data[i]= (byte) 0;
-        }
+        Arrays.fill(data, (byte) 0);
         check(0x8a9136aa); // aa 36 91 8a
     }
 
     @Test
     public void testOnes() {
-        for(int i = 0; i < data.length; i ++) {
-            data[i]= (byte) 0xFF;
-        }
+        Arrays.fill(data, (byte) 0xFF);
         check(0x62a8ab43); // 43 ab a8 62
     }