You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <de...@db.apache.org> on 2006/04/03 18:44:57 UTC
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_sed_SQLException.diff
This patch eliminates the diffs in a couple more derbyall tests under 1.6:
grantRevokeDDL
SURTest
savepointJdbc30*
iepnegativetests_ES
statementJdbc30
In addition, this patch gets rid of many of the jdk16-specific canons. What this patch does is add some masking logic to Sed.java to handle the fact that SQLException was split into subclasses in JDBC4. Derbyall runs cleanly (modulo expected diffs) under 1.4. The jdbc4 tests also run cleanly. The contents of this patch are:
M java\engine\org\apache\derby\impl\jdbc\Util.java
M java\testing\org\apache\derbyTesting\functionTests\tests\derbynet\testij.java
M java\testing\org\apache\derbyTesting\functionTests\harness\RunTest.java
M java\testing\org\apache\derbyTesting\functionTests\harness\Sed.java
M java\testing\org\apache\derbyTesting\functionTests\harness\JavaVersionHolder.java
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\importExport.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\procedure.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\ieptests.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\odbc_metadata.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\SURTest.out
M java\testing\org\apache\derbyTesting\functionTests\master\jdk16\closed.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\outparams.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\iepnegativetests.out
M java\testing\org\apache\derbyTesting\functionTests\master\jdk16\releaseCompileLocks.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\checkDataSource.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\procedure.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\statementJdbc20.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\statementJdbc30.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\Stream.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\checkDataSource30.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\nestedCommit.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\parameterMapping.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\TransactionTable.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\ieptests.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\importExportThruIJ.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\compressTable.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\streamingColumn.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\importExport.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\procedure.out
A java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\Stream.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\ieptests.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\odbc_metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\savepointJdbc30_JSR169.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\savepointJdbc30_XA.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\parameterMapping.out
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed_SQLException.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Mayuresh Nirhali <Ma...@Sun.COM>.
Hello,
attached svn status output to JIRA Derby-1072.
Thanks
Mayuresh
Rick Hillegas wrote:
> Hi Mayuresh,
>
> Thanks for the warning. Looks like Satheesh is reviewing your patch
> already. Could you do me a favor and attach the output of "svn status"
> to the JIRA so that I can see at a glance what files were changed?
>
> Thanks,
> -Rick
>
> Mayuresh Nirhali wrote:
>
>> Rick,
>>
>> I submitted a patch last week for DERBY-1072 which involved
>> modifications to lot of canon files.
>> I am hoping that someone would review that patch and commit if it is
>> okay ?
>> I thought I should let you know as lot of files I see in your list
>> are modified.
>>
>> Thanks
>> Mayuresh
>>
>> Rick Hillegas wrote:
>>
>>> Hi Bryan,
>>>
>>> Yes, please drop in your changes first. It turns out I'm going to
>>> have to regenerate this patch because a boatload of canon changes
>>> went in over the weekend. Are you planning to commit your changes
>>> today? It would be great if I could merge and regenerate
>>> mid-afternoon San Francisco time.
>>>
>>> Thanks,
>>> -Rick
>>>
>>>
>>> Bryan Pendleton wrote:
>>>
>>>>> In addition, this patch gets rid of many of the jdk16-specific
>>>>> canons.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Yay!
>>>>
>>>> The only downside is, both you and I want to touch
>>>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>>>> don't have an easy way to re-make my changes after yours, because I
>>>> don't have access to a JDK 1.6 environment yet.
>>>>
>>>> So can I submit my DERBY-349 change first?
>>>>
>>>> thanks,
>>>>
>>>> bryan
>>>>
>>>>
>>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Mayuresh,
Thanks for the warning. Looks like Satheesh is reviewing your patch
already. Could you do me a favor and attach the output of "svn status"
to the JIRA so that I can see at a glance what files were changed?
Thanks,
-Rick
Mayuresh Nirhali wrote:
> Rick,
>
> I submitted a patch last week for DERBY-1072 which involved
> modifications to lot of canon files.
> I am hoping that someone would review that patch and commit if it is
> okay ?
> I thought I should let you know as lot of files I see in your list are
> modified.
>
> Thanks
> Mayuresh
>
> Rick Hillegas wrote:
>
>> Hi Bryan,
>>
>> Yes, please drop in your changes first. It turns out I'm going to
>> have to regenerate this patch because a boatload of canon changes
>> went in over the weekend. Are you planning to commit your changes
>> today? It would be great if I could merge and regenerate
>> mid-afternoon San Francisco time.
>>
>> Thanks,
>> -Rick
>>
>>
>> Bryan Pendleton wrote:
>>
>>>> In addition, this patch gets rid of many of the jdk16-specific canons.
>>>
>>>
>>>
>>>
>>> Yay!
>>>
>>> The only downside is, both you and I want to touch
>>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>>> don't have an easy way to re-make my changes after yours, because I
>>> don't have access to a JDK 1.6 environment yet.
>>>
>>> So can I submit my DERBY-349 change first?
>>>
>>> thanks,
>>>
>>> bryan
>>>
>>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Mayuresh Nirhali <Ma...@Sun.COM>.
Rick,
I submitted a patch last week for DERBY-1072 which involved
modifications to lot of canon files.
I am hoping that someone would review that patch and commit if it is okay ?
I thought I should let you know as lot of files I see in your list are
modified.
Thanks
Mayuresh
Rick Hillegas wrote:
> Hi Bryan,
>
> Yes, please drop in your changes first. It turns out I'm going to have
> to regenerate this patch because a boatload of canon changes went in
> over the weekend. Are you planning to commit your changes today? It
> would be great if I could merge and regenerate mid-afternoon San
> Francisco time.
>
> Thanks,
> -Rick
>
>
> Bryan Pendleton wrote:
>
>>> In addition, this patch gets rid of many of the jdk16-specific canons.
>>
>>
>>
>> Yay!
>>
>> The only downside is, both you and I want to touch
>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>> don't have an easy way to re-make my changes after yours, because I
>> don't have access to a JDK 1.6 environment yet.
>>
>> So can I submit my DERBY-349 change first?
>>
>> thanks,
>>
>> bryan
>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
Rick Hillegas wrote:
> Yes, please drop in your changes first.
Thanks, Rick. I committed the test changes to subversion as:
http://svn.apache.org/viewcvs?rev=391086&view=rev
thanks,
bryan
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Bryan,
Yes, please drop in your changes first. It turns out I'm going to have
to regenerate this patch because a boatload of canon changes went in
over the weekend. Are you planning to commit your changes today? It
would be great if I could merge and regenerate mid-afternoon San
Francisco time.
Thanks,
-Rick
Bryan Pendleton wrote:
>> In addition, this patch gets rid of many of the jdk16-specific canons.
>
>
> Yay!
>
> The only downside is, both you and I want to touch
> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
> don't have an easy way to re-make my changes after yours, because I
> don't have access to a JDK 1.6 environment yet.
>
> So can I submit my DERBY-349 change first?
>
> thanks,
>
> bryan
>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
> In addition, this patch gets rid of many of the jdk16-specific canons.
Yay!
The only downside is, both you and I want to touch
master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
don't have an easy way to re-make my changes after yours, because I
don't have access to a JDK 1.6 environment yet.
So can I submit my DERBY-349 change first?
thanks,
bryan