You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/06 11:53:39 UTC
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2529: [KYUUBI #2493] Implement the progress of statement
turboFei commented on code in PR #2529:
URL: https://github.com/apache/incubator-kyuubi/pull/2529#discussion_r866753554
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -157,6 +160,11 @@ class ExecuteStatement(
SparkOperationEvent(this, operationListener.getExecutionId))
}
+ override def getStatus: OperationStatus = {
+ setOperationJobProgress(progressFetcher.getJobProgressUpdate(startTime))
Review Comment:
nice feature.
I have a question. is the getJobProgressUpdate operation is heavy?
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala:
##########
@@ -157,6 +160,11 @@ class ExecuteStatement(
SparkOperationEvent(this, operationListener.getExecutionId))
}
+ override def getStatus: OperationStatus = {
+ setOperationJobProgress(progressFetcher.getJobProgressUpdate(startTime))
Review Comment:
nice feature.
I have a question. is the getJobProgressUpdate operation heavy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org