You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by Jinjiang <gi...@git.apache.org> on 2017/01/31 04:35:16 UTC
[GitHub] incubator-weex pull request #1: Weex 17
GitHub user Jinjiang opened a pull request:
https://github.com/apache/incubator-weex/pull/1
Weex 17
Accepted weex variable from JS runtime before `legacyFramework.createInstance`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jinjiang/incubator-weex WEEX-17
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit b4746e42b6b7439b6fa2464258cd26ed941bf1eb
Author: \u52fe\u4e09\u80a1\u56db <zh...@me.com>
Date: 2017-01-31T04:22:07Z
[jsfm] Accepted external document instance.
commit a982e091bc2dd77dd8d7de3913a7c14d5f52d462
Author: \u52fe\u4e09\u80a1\u56db <zh...@me.com>
Date: 2017-01-31T04:31:00Z
[jsfm] Accepted external weex global var.
commit c09c5dbc52d133480b10fe2379707c2d5eec27e3
Author: \u52fe\u4e09\u80a1\u56db <zh...@me.com>
Date: 2017-01-31T04:33:41Z
[jsfm] Accepted info.weex in legacy framework.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #1: [WEEX-17] Abstract a common weex var for each JS fr...
Posted by edwardyoon <gi...@git.apache.org>.
Github user edwardyoon commented on the issue:
https://github.com/apache/incubator-weex/pull/1
Just FYI, usually one commit per pull request[1] is recommended. Once it synced with apache git, you can't change or clean up commit histories.
1. http://ndlib.github.io/practices/one-commit-per-pull-request/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #1: [WEEX-17] Abstract a common weex var for eac...
Posted by Jinjiang <gi...@git.apache.org>.
Github user Jinjiang closed the pull request at:
https://github.com/apache/incubator-weex/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---