You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2015/08/12 14:09:12 UTC

tapestry-5 git commit: append single characters as chars

Repository: tapestry-5
Updated Branches:
  refs/heads/master 7bfc88ebb -> 131f53f8a


append single characters as chars


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/131f53f8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/131f53f8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/131f53f8

Branch: refs/heads/master
Commit: 131f53f8a7d809b8492abe1a9f02a309788e1565
Parents: 7bfc88e
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Wed Aug 12 14:08:36 2015 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Wed Aug 12 14:08:36 2015 +0200

----------------------------------------------------------------------
 .../tapestry5/internal/beaneditor/BeanModelImpl.java    |  2 +-
 .../internal/services/PropertyConduitSourceImpl.java    |  4 ++--
 .../ioc/internal/services/PlasticProxyFactoryImpl.java  |  4 ++--
 .../org/apache/tapestry5/internal/util/MultiKey.java    |  2 +-
 .../ioc/internal/util/InternalCommonsUtils.java         |  6 +++---
 .../apache/tapestry5/ioc/util/CaseInsensitiveMap.java   |  2 +-
 .../main/java/org/apache/tapestry5/ioc/util/Stack.java  |  2 +-
 .../tapestry5/internal/plastic/asm/util/ASMifier.java   |  4 ++--
 .../internal/plastic/asm/xml/SAXAnnotationAdapter.java  |  6 +++---
 .../apache/tapestry5/internal/plastic/NameCache.java    |  2 +-
 .../tapestry5/internal/plastic/PlasticClassPool.java    |  2 +-
 .../internal/plastic/PlasticInternalUtils.java          |  4 ++--
 .../org/apache/tapestry5/plastic/MethodDescription.java | 12 ++++++------
 .../tapestry5/internal/clojure/DefaultMapper.java       |  2 +-
 .../src/main/java/org/apache/tapestry5/ContentType.java |  4 ++--
 .../main/java/org/apache/tapestry5/dom/Attribute.java   |  4 ++--
 .../src/main/java/org/apache/tapestry5/dom/Element.java |  6 +++---
 .../apache/tapestry5/internal/AbstractEventContext.java |  2 +-
 .../internal/pageload/CompositeRenderCommand.java       |  2 +-
 .../tapestry5/internal/parser/AttributeToken.java       |  4 ++--
 .../tapestry5/internal/parser/StartComponentToken.java  |  6 +++---
 .../tapestry5/internal/parser/StartElementToken.java    |  4 ++--
 .../services/ComponentEventLinkEncoderImpl.java         |  2 +-
 .../internal/services/ContextPathEncoderImpl.java       |  2 +-
 .../apache/tapestry5/internal/services/LinkImpl.java    |  2 +-
 .../internal/services/PathConstructorImpl.java          |  2 +-
 .../services/assets/AssetPathConstructorImpl.java       |  4 ++--
 .../messages/ClientLocalizationMessageResource.java     |  2 +-
 .../tapestry5/services/javascript/AMDWrapper.java       |  2 +-
 .../services/javascript/StylesheetOptions.java          |  2 +-
 .../services/pageload/ComponentResourceSelector.java    |  2 +-
 .../app1/pages/MapExpressionInExpansions.java           |  6 +++---
 .../services/AppPageRenderLinkTransformer.java          |  4 ++--
 .../tapestry5/internal/test/InternalBaseTestCase.java   |  2 +-
 .../src/main/java/org/apache/tapestry5/func/Tuple.java  |  2 +-
 .../test/java/org/apache/tapestry5/func/FuncTest.java   | 12 ++++++------
 .../main/java/org/apache/tapestry5/ioc/Orderable.java   |  6 +++---
 .../tapestry5/ioc/internal/services/MethodLogger.java   |  2 +-
 .../ioc/internal/services/MethodSignature.java          | 12 ++++++------
 .../internal/services/cron/PeriodicExecutorImpl.java    |  4 ++--
 .../tapestry5/ioc/internal/util/DependencyNode.java     |  2 +-
 .../java/org/apache/tapestry5/ioc/test/IOCTestCase.java |  2 +-
 .../apache/tapestry5/javadoc/ParameterDescription.java  |  2 +-
 .../tapestry5/test/ErrorReportingCommandProcessor.java  |  6 +++---
 .../yahoo/platform/yui/compressor/CssCompressor.java    |  2 +-
 45 files changed, 85 insertions(+), 85 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/beanmodel/src/main/java/org/apache/tapestry5/internal/beaneditor/BeanModelImpl.java
----------------------------------------------------------------------
diff --git a/beanmodel/src/main/java/org/apache/tapestry5/internal/beaneditor/BeanModelImpl.java b/beanmodel/src/main/java/org/apache/tapestry5/internal/beaneditor/BeanModelImpl.java
index 3b71f0e..4d2245d 100644
--- a/beanmodel/src/main/java/org/apache/tapestry5/internal/beaneditor/BeanModelImpl.java
+++ b/beanmodel/src/main/java/org/apache/tapestry5/internal/beaneditor/BeanModelImpl.java
@@ -282,7 +282,7 @@ public class BeanModelImpl<T> implements BeanModel<T>
             sep = ", ";
         }
 
-        builder.append("]");
+        builder.append(']');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/beanmodel/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
----------------------------------------------------------------------
diff --git a/beanmodel/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java b/beanmodel/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
index 9148b46..58820db 100644
--- a/beanmodel/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
+++ b/beanmodel/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
@@ -1548,7 +1548,7 @@ public class PropertyConduitSourceImpl implements PropertyConduitSource
 
     private static String toUniqueId(Method method)
     {
-        StringBuilder builder = new StringBuilder(method.getName()).append("(");
+        StringBuilder builder = new StringBuilder(method.getName()).append('(');
         String sep = "";
 
         for (Class parameterType : method.getParameterTypes())
@@ -1559,7 +1559,7 @@ public class PropertyConduitSourceImpl implements PropertyConduitSource
             sep = ",";
         }
 
-        return builder.append(")").toString();
+        return builder.append(')').toString();
     }
     
 }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java
----------------------------------------------------------------------
diff --git a/beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java b/beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java
index a23ecec..dc5397c 100644
--- a/beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java
+++ b/beanmodel/src/main/java/org/apache/tapestry5/ioc/internal/services/PlasticProxyFactoryImpl.java
@@ -174,7 +174,7 @@ public class PlasticProxyFactoryImpl implements PlasticProxyFactory
             @Override
             public String createObject()
             {
-                StringBuilder builder = new StringBuilder(constructor.getDeclaringClass().getName()).append("(");
+                StringBuilder builder = new StringBuilder(constructor.getDeclaringClass().getName()).append('(');
                 String sep = "";
 
                 for (Class parameterType : constructor.getParameterTypes())
@@ -185,7 +185,7 @@ public class PlasticProxyFactoryImpl implements PlasticProxyFactory
                     sep = ", ";
                 }
 
-                builder.append(")");
+                builder.append(')');
 
                 return builder.toString();
             }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/commons/src/main/java/org/apache/tapestry5/internal/util/MultiKey.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/tapestry5/internal/util/MultiKey.java b/commons/src/main/java/org/apache/tapestry5/internal/util/MultiKey.java
index 503bb1f..5d6f283 100644
--- a/commons/src/main/java/org/apache/tapestry5/internal/util/MultiKey.java
+++ b/commons/src/main/java/org/apache/tapestry5/internal/util/MultiKey.java
@@ -78,7 +78,7 @@ public final class MultiKey
             first = false;
         }
 
-        builder.append("]");
+        builder.append(']');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalCommonsUtils.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalCommonsUtils.java b/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalCommonsUtils.java
index 2bc33d8..cbad70e 100644
--- a/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalCommonsUtils.java
+++ b/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalCommonsUtils.java
@@ -209,9 +209,9 @@ public class InternalCommonsUtils {
         StringBuilder buffer = new StringBuilder();
     
         buffer.append(method.getDeclaringClass().getName());
-        buffer.append(".");
+        buffer.append('.');
         buffer.append(method.getName());
-        buffer.append("(");
+        buffer.append('(');
     
         for (int i = 0; i < method.getParameterTypes().length; i++)
         {
@@ -223,7 +223,7 @@ public class InternalCommonsUtils {
             buffer.append(name);
         }
     
-        return buffer.append(")").toString();
+        return buffer.append(')').toString();
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/commons/src/main/java/org/apache/tapestry5/ioc/util/CaseInsensitiveMap.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/tapestry5/ioc/util/CaseInsensitiveMap.java b/commons/src/main/java/org/apache/tapestry5/ioc/util/CaseInsensitiveMap.java
index 7862f9f..60bec02 100644
--- a/commons/src/main/java/org/apache/tapestry5/ioc/util/CaseInsensitiveMap.java
+++ b/commons/src/main/java/org/apache/tapestry5/ioc/util/CaseInsensitiveMap.java
@@ -96,7 +96,7 @@ public class CaseInsensitiveMap<V> extends AbstractMap<String, V> implements Ser
         @Override
         public String toString() {
           StringBuilder builder = new StringBuilder();
-          builder.append("CIMEntry [key=").append(key).append(", value=").append(value).append("]");
+          builder.append("CIMEntry [key=").append(key).append(", value=").append(value).append(']');
           return builder.toString();
         }
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/commons/src/main/java/org/apache/tapestry5/ioc/util/Stack.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/tapestry5/ioc/util/Stack.java b/commons/src/main/java/org/apache/tapestry5/ioc/util/Stack.java
index cfa13a0..4775888 100644
--- a/commons/src/main/java/org/apache/tapestry5/ioc/util/Stack.java
+++ b/commons/src/main/java/org/apache/tapestry5/ioc/util/Stack.java
@@ -150,7 +150,7 @@ public class Stack<E>
             builder.append(String.valueOf(items[i]));
         }
 
-        builder.append("]");
+        builder.append(']');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java
----------------------------------------------------------------------
diff --git a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java
index 7d6339d..c7b8f7f 100644
--- a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java
+++ b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/util/ASMifier.java
@@ -896,8 +896,8 @@ public class ASMifier extends Printer {
     public ASMifier visitTypeAnnotation(final String method, final int typeRef,
             final TypePath typePath, final String desc, final boolean visible) {
         buf.setLength(0);
-        buf.append("{\n").append("av0 = ").append(name).append(".")
-                .append(method).append("(");
+        buf.append("{\n").append("av0 = ").append(name).append('.')
+                .append(method).append('(');
         buf.append(typeRef);
         buf.append(", TypePath.fromString(\"").append(typePath).append("\"), ");
         appendConstant(desc);

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java
----------------------------------------------------------------------
diff --git a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java
index 5ac25e4..76e5b8e 100644
--- a/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java
+++ b/plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/xml/SAXAnnotationAdapter.java
@@ -115,14 +115,14 @@ public final class SAXAnnotationAdapter extends AnnotationVisitor {
         if (start != null) {
             StringBuffer value = new StringBuffer(start[0]);
             for (int i = 1; i < start.length; ++i) {
-                value.append(" ").append(start[i]);
+                value.append(' ').append(start[i]);
             }
             att.addAttribute("", "start", "start", "", value.toString());
         }
         if (end != null) {
             StringBuffer value = new StringBuffer(end[0]);
             for (int i = 1; i < end.length; ++i) {
-                value.append(" ").append(end[i]);
+                value.append(' ').append(end[i]);
             }
             att.addAttribute("", "end", "end", "", value.toString());
         }
@@ -130,7 +130,7 @@ public final class SAXAnnotationAdapter extends AnnotationVisitor {
             StringBuffer value = new StringBuffer();
             value.append(index[0]);
             for (int i = 1; i < index.length; ++i) {
-                value.append(" ").append(index[i]);
+                value.append(' ').append(index[i]);
             }
             att.addAttribute("", "index", "index", "", value.toString());
         }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/main/java/org/apache/tapestry5/internal/plastic/NameCache.java
----------------------------------------------------------------------
diff --git a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/NameCache.java b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/NameCache.java
index 5703feb..eaaf826 100644
--- a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/NameCache.java
+++ b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/NameCache.java
@@ -119,7 +119,7 @@ public class NameCache
             builder.append(toDesc(argumentType));
         }
 
-        builder.append(")").append(toDesc(returnType));
+        builder.append(')').append(toDesc(returnType));
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java
----------------------------------------------------------------------
diff --git a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java
index b8e2bb4..290821b 100644
--- a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java
+++ b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassPool.java
@@ -636,7 +636,7 @@ public class PlasticClassPool implements ClassLoaderDelegate, Opcodes, PlasticCl
                     sep = ", ";
                 }
 
-                String message = b.append(".").toString();
+                String message = b.append('.').toString();
 
                 throw new IllegalArgumentException(message);
             }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticInternalUtils.java
----------------------------------------------------------------------
diff --git a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticInternalUtils.java b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticInternalUtils.java
index aae8340..8dc86a3 100644
--- a/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticInternalUtils.java
+++ b/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticInternalUtils.java
@@ -307,10 +307,10 @@ public class PlasticInternalUtils
 
         for (int i = 0; i < depth; i++)
         {
-            builder.append("[");
+            builder.append('[');
         }
 
-        builder.append("L").append(javaName).append(";");
+        builder.append('L').append(javaName).append(';');
 
         return Class.forName(builder.toString(), true, loader);
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/plastic/src/main/java/org/apache/tapestry5/plastic/MethodDescription.java
----------------------------------------------------------------------
diff --git a/plastic/src/main/java/org/apache/tapestry5/plastic/MethodDescription.java b/plastic/src/main/java/org/apache/tapestry5/plastic/MethodDescription.java
index 66daaeb..e0b7d2a 100644
--- a/plastic/src/main/java/org/apache/tapestry5/plastic/MethodDescription.java
+++ b/plastic/src/main/java/org/apache/tapestry5/plastic/MethodDescription.java
@@ -188,9 +188,9 @@ public class MethodDescription implements Comparable<MethodDescription>
         // as modifiers. We'll have to see.
 
         if (modifiers != 0)
-            builder.append(Modifier.toString(modifiers)).append(" ");
+            builder.append(Modifier.toString(modifiers)).append(' ');
 
-        builder.append(returnType).append(" ").append(methodName).append("(");
+        builder.append(returnType).append(' ').append(methodName).append('(');
 
         String sep = "";
 
@@ -202,10 +202,10 @@ public class MethodDescription implements Comparable<MethodDescription>
             sep = ", ";
         }
 
-        builder.append(")");
+        builder.append(')');
 
         if (genericSignature != null)
-            builder.append(" <").append(genericSignature).append(">");
+            builder.append(" <").append(genericSignature).append('>');
 
         sep = " throws ";
 
@@ -228,7 +228,7 @@ public class MethodDescription implements Comparable<MethodDescription>
      */
     public String toShortString()
     {
-        StringBuilder builder = new StringBuilder(methodName).append("(");
+        StringBuilder builder = new StringBuilder(methodName).append('(');
 
         String sep = "";
 
@@ -239,6 +239,6 @@ public class MethodDescription implements Comparable<MethodDescription>
             sep = ", ";
         }
 
-        return builder.append(")").toString();
+        return builder.append(')').toString();
     }
 }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-clojure/src/main/java/org/apache/tapestry5/internal/clojure/DefaultMapper.java
----------------------------------------------------------------------
diff --git a/tapestry-clojure/src/main/java/org/apache/tapestry5/internal/clojure/DefaultMapper.java b/tapestry-clojure/src/main/java/org/apache/tapestry5/internal/clojure/DefaultMapper.java
index cfdf0cf..526a036 100644
--- a/tapestry-clojure/src/main/java/org/apache/tapestry5/internal/clojure/DefaultMapper.java
+++ b/tapestry-clojure/src/main/java/org/apache/tapestry5/internal/clojure/DefaultMapper.java
@@ -57,7 +57,7 @@ public class DefaultMapper implements MethodToFunctionSymbolMapper
             int end = matchResult.end();
 
             builder.append(name.substring(lastx, start + 1));
-            builder.append("-");
+            builder.append('-');
             // TODO: An acronym (such as "URL") should not be lower cased here.
             builder.append(name.substring(end - 1, end).toLowerCase());
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/ContentType.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/ContentType.java b/tapestry-core/src/main/java/org/apache/tapestry5/ContentType.java
index 04362a8..245a52a 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/ContentType.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/ContentType.java
@@ -163,9 +163,9 @@ public final class ContentType
 
         for (String parameterName : getParameterNames())
         {
-            buffer.append(";");
+            buffer.append(';');
             buffer.append(parameterName);
-            buffer.append("=");
+            buffer.append('=');
             buffer.append(parameters.get(parameterName));
         }
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/dom/Attribute.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Attribute.java b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Attribute.java
index 18db8c6..742a10c 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Attribute.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Attribute.java
@@ -62,9 +62,9 @@ public class Attribute
 
     void render(MarkupModel model, StringBuilder builder, Map<String, String> namespaceURIToPrefix)
     {
-        builder.append(" ");
+        builder.append(' ');
         builder.append(element.toPrefixedName(namespaceURIToPrefix, namespace, name));
-        builder.append("=");
+        builder.append('=');
         builder.append(model.getAttributeQuote());
         model.encodeQuoted(value, builder);
         builder.append(model.getAttributeQuote());

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
index bf1eadf..cbc29b5 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java
@@ -377,7 +377,7 @@ public final class Element extends Node
 
         String prefixedElementName = toPrefixedName(localNamespacePrefixToURI, namespace, name);
 
-        builder.append("<").append(prefixedElementName);
+        builder.append('<').append(prefixedElementName);
 
         // Output order used to be alpha sorted, but now it tends to be the inverse
         // of the order in which attributes were added.
@@ -402,10 +402,10 @@ public final class Element extends Node
 
             if (!prefix.equals(""))
             {
-                builder.append(":").append(prefix);
+                builder.append(':').append(prefix);
             }
 
-            builder.append("=");
+            builder.append('=');
             builder.append(markupModel.getAttributeQuote());
 
             markupModel.encodeQuoted(namespace, builder);

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/AbstractEventContext.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/AbstractEventContext.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/AbstractEventContext.java
index 443a01a..f1738e3 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/AbstractEventContext.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/AbstractEventContext.java
@@ -47,6 +47,6 @@ public abstract class AbstractEventContext implements EventContext
             sep = ", ";
         }
 
-        return builder.append(">").toString();
+        return builder.append('>').toString();
     }
 }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/pageload/CompositeRenderCommand.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/pageload/CompositeRenderCommand.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/pageload/CompositeRenderCommand.java
index 17de6ba..5365b5e 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/pageload/CompositeRenderCommand.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/pageload/CompositeRenderCommand.java
@@ -84,6 +84,6 @@ class CompositeRenderCommand implements RenderCommand
             comma = true;
         }
 
-        return builder.append("]").toString();
+        return builder.append(']').toString();
     }
 }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/AttributeToken.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/AttributeToken.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/AttributeToken.java
index fde3d0d..28d037f 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/AttributeToken.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/AttributeToken.java
@@ -50,9 +50,9 @@ public class AttributeToken extends TemplateToken implements RenderCommand
     {
         StringBuilder builder = new StringBuilder("Attribute[");
 
-        if (namespaceURI.length() > 0) builder.append(namespaceURI).append(" ");
+        if (namespaceURI.length() > 0) builder.append(namespaceURI).append(' ');
 
-        builder.append(name).append("=").append(value).append("]");
+        builder.append(name).append('=').append(value).append(']');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartComponentToken.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartComponentToken.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartComponentToken.java
index 8ceaf77..35fc40f 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartComponentToken.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartComponentToken.java
@@ -93,7 +93,7 @@ public class StartComponentToken extends TemplateToken
         add(builder, "mixins", mixins);
 
         builder.insert(0, "StartComponentToken[");
-        builder.append("]");
+        builder.append(']');
 
         return builder.toString();
     }
@@ -104,10 +104,10 @@ public class StartComponentToken extends TemplateToken
             return;
 
         if (builder.length() > 0)
-            builder.append(" ");
+            builder.append(' ');
 
         builder.append(label);
-        builder.append("=");
+        builder.append('=');
         builder.append(value);
     }
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartElementToken.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartElementToken.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartElementToken.java
index 194a1cc..ee2a986 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartElementToken.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/parser/StartElementToken.java
@@ -45,9 +45,9 @@ public class StartElementToken extends TemplateToken implements RenderCommand
     {
         StringBuilder builder = new StringBuilder("Start[");
 
-        if (namespaceURI != null && namespaceURI.length() > 0) builder.append(namespaceURI).append(" ");
+        if (namespaceURI != null && namespaceURI.length() > 0) builder.append(namespaceURI).append(' ');
 
-        builder.append(name).append("]");
+        builder.append(name).append(']');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java
index 79d90cc..129d1dc 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java
@@ -179,7 +179,7 @@ public class ComponentEventLinkEncoderImpl implements ComponentEventLinkEncoder
 
         if (!hasComponentId || !eventType.equals(EventConstants.ACTION))
         {
-            builder.append(":");
+            builder.append(':');
             builder.append(encodePageName(eventType));
         }
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ContextPathEncoderImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ContextPathEncoderImpl.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ContextPathEncoderImpl.java
index 33ddcd8..9974d66 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ContextPathEncoderImpl.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ContextPathEncoderImpl.java
@@ -72,7 +72,7 @@ public class ContextPathEncoderImpl implements ContextPathEncoder
             String urlEncoded = encodeValue(raw);
 
             if (i > 0)
-                output.append("/");
+                output.append('/');
 
             output.append(urlEncoded);
         }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LinkImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LinkImpl.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LinkImpl.java
index 8d4f62f..fafcad5 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LinkImpl.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LinkImpl.java
@@ -231,7 +231,7 @@ public class LinkImpl implements Link
                     // encoded if it is not known to be URL safe.
 
                     builder.append(name);
-                    builder.append("=");
+                    builder.append('=');
                     builder.append(value);
 
                     sep = "&";

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PathConstructorImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PathConstructorImpl.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PathConstructorImpl.java
index 9612cf2..c8ac646 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PathConstructorImpl.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PathConstructorImpl.java
@@ -31,7 +31,7 @@ public class PathConstructorImpl implements PathConstructor
         if (applicationFolder.length() > 0)
         {
             b.append(applicationFolder);
-            b.append("/");
+            b.append('/');
         }
 
         dispatchPrefix = b.toString();

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
index e8a3231..5657463 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
@@ -76,13 +76,13 @@ public class AssetPathConstructorImpl implements AssetPathConstructor
 
         builder.append(prefix);
         builder.append(virtualFolder);
-        builder.append("/");
+        builder.append('/');
 
         // The 'z' prefix indicates a compressed resource.
 
         if (resource.getCompression() == CompressionStatus.COMPRESSED)
         {
-            builder.append("z");
+            builder.append('z');
         }
 
         builder.append(resource.getChecksum());

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/messages/ClientLocalizationMessageResource.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/messages/ClientLocalizationMessageResource.java b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/messages/ClientLocalizationMessageResource.java
index cbd56bd..6058997 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/messages/ClientLocalizationMessageResource.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/messages/ClientLocalizationMessageResource.java
@@ -117,6 +117,6 @@ public class ClientLocalizationMessageResource extends VirtualResource
 
     private void write(StringBuilder builder, String name, Object value)
     {
-        builder.append(name).append("=").append(value).append("\n");
+        builder.append(name).append('=').append(value).append('\n');
     }
 }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/AMDWrapper.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/AMDWrapper.java b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/AMDWrapper.java
index ee98504..6c940fe 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/AMDWrapper.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/AMDWrapper.java
@@ -186,7 +186,7 @@ public class AMDWrapper {
             {
                 sb.append("\nreturn ");
                 sb.append(returnExpression);
-                sb.append(";");
+                sb.append(';');
             }
             sb.append("\n});");
             trailerStream = toInputStream(sb);

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StylesheetOptions.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StylesheetOptions.java b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StylesheetOptions.java
index ae1edd0..186554a 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StylesheetOptions.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/StylesheetOptions.java
@@ -116,7 +116,7 @@ public final class StylesheetOptions
             sep = " ";
         }
 
-        return builder.append("]").toString();
+        return builder.append(']').toString();
     }
 
     @Override

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java b/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java
index 3db3cd7..2f4dbac 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java
@@ -128,7 +128,7 @@ public final class ComponentResourceSelector
         {
             builder.append(sep);
             builder.append(e.getKey().getName());
-            builder.append("=");
+            builder.append('=');
             builder.append(e.getValue().toString());
 
             sep = ", ";

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MapExpressionInExpansions.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MapExpressionInExpansions.java b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MapExpressionInExpansions.java
index 25561af..5f47c22 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MapExpressionInExpansions.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MapExpressionInExpansions.java
@@ -32,15 +32,15 @@ public class MapExpressionInExpansions
         for (Map.Entry entry : value.entrySet())
         {
             builder.append(entry.getKey())
-                   .append(":")
+                   .append(':')
                    .append(entry.getValue())
-                   .append(",");
+                   .append(',');
         }
 
         if (builder.length() > 1)
             builder.deleteCharAt(builder.length()-1);
 
-        builder.append("}");
+        builder.append('}');
 
         return builder.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/test/java/org/apache/tapestry5/integration/linktrans/services/AppPageRenderLinkTransformer.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/integration/linktrans/services/AppPageRenderLinkTransformer.java b/tapestry-core/src/test/java/org/apache/tapestry5/integration/linktrans/services/AppPageRenderLinkTransformer.java
index ed80d7c..d04764b 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/integration/linktrans/services/AppPageRenderLinkTransformer.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/integration/linktrans/services/AppPageRenderLinkTransformer.java
@@ -81,9 +81,9 @@ public class AppPageRenderLinkTransformer implements PageRenderLinkTransformer
         Locale locale = persistentLocale.get();
 
         if (locale != null)
-            path.append("/").append(locale.toString());
+            path.append('/').append(locale.toString());
 
-        path.append("/");
+        path.append('/');
 
         // Cheating: we know there's exactly one value in the context.
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java b/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
index 42d01c8..92b109c 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
@@ -294,7 +294,7 @@ public class InternalBaseTestCase extends TapestryTestCase implements Registry
 
             buffer.append(line);
 
-            buffer.append("\n");
+            buffer.append('\n');
         }
 
         in.close();

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-func/src/main/java/org/apache/tapestry5/func/Tuple.java
----------------------------------------------------------------------
diff --git a/tapestry-func/src/main/java/org/apache/tapestry5/func/Tuple.java b/tapestry-func/src/main/java/org/apache/tapestry5/func/Tuple.java
index 1188db4..86625f3 100644
--- a/tapestry-func/src/main/java/org/apache/tapestry5/func/Tuple.java
+++ b/tapestry-func/src/main/java/org/apache/tapestry5/func/Tuple.java
@@ -53,7 +53,7 @@ public class Tuple<A, B>
 
         extendDescription(builder);
 
-        return builder.append(")").toString();
+        return builder.append(')').toString();
     }
 
     /**

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java
----------------------------------------------------------------------
diff --git a/tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java b/tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java
index 0d63d02..b459ee9 100644
--- a/tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java
+++ b/tapestry-func/src/test/java/org/apache/tapestry5/func/FuncTest.java
@@ -64,7 +64,7 @@ public class FuncTest extends BaseFuncTest
             public void work(String value)
             {
                 if (buffer.length() > 0)
-                    buffer.append(" ");
+                    buffer.append(' ');
 
                 buffer.append(value);
             }
@@ -88,7 +88,7 @@ public class FuncTest extends BaseFuncTest
             public void work(String value)
             {
                 if (buffer.length() > 0)
-                    buffer.append(" ");
+                    buffer.append(' ');
 
                 buffer.append(value);
             }
@@ -119,7 +119,7 @@ public class FuncTest extends BaseFuncTest
             public void work(String value)
             {
                 if (buffer.length() > 0)
-                    buffer.append(" ");
+                    buffer.append(' ');
 
                 buffer.append(value);
             }
@@ -141,7 +141,7 @@ public class FuncTest extends BaseFuncTest
             public void work(String value)
             {
                 if (buffer.length() > 0)
-                    buffer.append(" ");
+                    buffer.append(' ');
 
                 buffer.append(value);
             }
@@ -152,9 +152,9 @@ public class FuncTest extends BaseFuncTest
             @Override
             public void work(String value)
             {
-                buffer.append("(");
+                buffer.append('(');
                 buffer.append(value.length());
-                buffer.append(")");
+                buffer.append(')');
             }
         };
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/Orderable.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/Orderable.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/Orderable.java
index 7805a08..a7d084b 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/Orderable.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/Orderable.java
@@ -68,13 +68,13 @@ public class Orderable<T>
 
         for (String c : constraints)
         {
-            buffer.append(" ");
+            buffer.append(' ');
             buffer.append(c);
         }
 
-        buffer.append(" ");
+        buffer.append(' ');
         buffer.append(target.toString());
-        buffer.append("]");
+        buffer.append(']');
 
         return buffer.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodLogger.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodLogger.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodLogger.java
index 0735fd1..84c2ee1 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodLogger.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodLogger.java
@@ -69,7 +69,7 @@ public final class MethodLogger
             convert(buffer, invocation.getParameter(i));
         }
 
-        buffer.append(")");
+        buffer.append(')');
 
         logger.debug(buffer.toString());
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodSignature.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodSignature.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodSignature.java
index 101abea..a89f8c0 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodSignature.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/MethodSignature.java
@@ -177,9 +177,9 @@ public class MethodSignature
         StringBuilder buffer = new StringBuilder();
 
         buffer.append(PlasticUtils.toTypeName(returnType));
-        buffer.append(" ");
+        buffer.append(' ');
         buffer.append(name);
-        buffer.append("(");
+        buffer.append('(');
 
         for (int i = 0; i < InternalUtils.size(parameterTypes); i++)
         {
@@ -189,7 +189,7 @@ public class MethodSignature
             buffer.append(PlasticUtils.toTypeName(parameterTypes[i]));
         }
 
-        buffer.append(")");
+        buffer.append(')');
 
         int _exceptionCount = InternalUtils.size(exceptionTypes);
         String _exceptionNames[] = new String[_exceptionCount];
@@ -224,17 +224,17 @@ public class MethodSignature
     public String getUniqueId()
     {
         StringBuilder buffer = new StringBuilder(name);
-        buffer.append("(");
+        buffer.append('(');
 
         for (int i = 0; i < InternalUtils.size(parameterTypes); i++)
         {
             if (i > 0)
-                buffer.append(",");
+                buffer.append(',');
 
             buffer.append(PlasticUtils.toTypeName(parameterTypes[i]));
         }
 
-        buffer.append(")");
+        buffer.append(')');
 
         return buffer.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/PeriodicExecutorImpl.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/PeriodicExecutorImpl.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/PeriodicExecutorImpl.java
index f50a077..a1b2a80 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/PeriodicExecutorImpl.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/PeriodicExecutorImpl.java
@@ -143,7 +143,7 @@ public class PeriodicExecutorImpl implements PeriodicExecutor, Runnable
         {
             StringBuilder builder = new StringBuilder("PeriodicJob[#").append(jobId);
 
-            builder.append(", (").append(name).append(")");
+            builder.append(", (").append(name).append(')');
 
             if (executing)
             {
@@ -158,7 +158,7 @@ public class PeriodicExecutorImpl implements PeriodicExecutor, Runnable
                 builder.append(String.format(", next execution %Tk:%<TM:%<TS+%<TL", nextExecution));
             }
 
-            return builder.append("]").toString();
+            return builder.append(']').toString();
         }
 
         /**

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/DependencyNode.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/DependencyNode.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/DependencyNode.java
index 04ca3e5..5b039c7 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/DependencyNode.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/DependencyNode.java
@@ -58,7 +58,7 @@ class DependencyNode<T>
             first = false;
         }
 
-        buffer.append("]");
+        buffer.append(']');
 
         return buffer.toString();
     }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/IOCTestCase.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/IOCTestCase.java b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/IOCTestCase.java
index 332377d..e1a765b 100644
--- a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/IOCTestCase.java
+++ b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/IOCTestCase.java
@@ -81,7 +81,7 @@ public class IOCTestCase extends TestBase
         for (String line : lines)
         {
             result.append(line);
-            result.append("\n");
+            result.append('\n');
         }
 
         return result.toString();

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ParameterDescription.java
----------------------------------------------------------------------
diff --git a/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ParameterDescription.java b/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ParameterDescription.java
index ff8bc11..8ff25fc 100644
--- a/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ParameterDescription.java
+++ b/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ParameterDescription.java
@@ -102,7 +102,7 @@ public class ParameterDescription
 
                 if (seeTag.referencedMemberName() != null)
                 {
-                    builder.append("#");
+                    builder.append('#');
                     builder.append(StringEscapeUtils.escapeHtml(seeTag.referencedMemberName()));
                 }
             }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-test/src/main/java/org/apache/tapestry5/test/ErrorReportingCommandProcessor.java
----------------------------------------------------------------------
diff --git a/tapestry-test/src/main/java/org/apache/tapestry5/test/ErrorReportingCommandProcessor.java b/tapestry-test/src/main/java/org/apache/tapestry5/test/ErrorReportingCommandProcessor.java
index af3e7b8..1fafe82 100644
--- a/tapestry-test/src/main/java/org/apache/tapestry5/test/ErrorReportingCommandProcessor.java
+++ b/tapestry-test/src/main/java/org/apache/tapestry5/test/ErrorReportingCommandProcessor.java
@@ -40,7 +40,7 @@ public class ErrorReportingCommandProcessor implements CommandProcessor
 
         builder.append("Selenium failure processing command ");
         builder.append(command);
-        builder.append("(");
+        builder.append('(');
 
         for (int i = 0; i < args.length; i++)
         {
@@ -61,9 +61,9 @@ public class ErrorReportingCommandProcessor implements CommandProcessor
             if (logs != null && logs.length() > 0)
             {
 
-                builder.append("\n");
+                builder.append('\n');
                 builder.append(BORDER);
-                builder.append("\n");
+                builder.append('\n');
 
                 builder.append(logs);
             }

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/131f53f8/tapestry-webresources/src/main/java/com/yahoo/platform/yui/compressor/CssCompressor.java
----------------------------------------------------------------------
diff --git a/tapestry-webresources/src/main/java/com/yahoo/platform/yui/compressor/CssCompressor.java b/tapestry-webresources/src/main/java/com/yahoo/platform/yui/compressor/CssCompressor.java
index 6db09d7..c5e2ec0 100644
--- a/tapestry-webresources/src/main/java/com/yahoo/platform/yui/compressor/CssCompressor.java
+++ b/tapestry-webresources/src/main/java/com/yahoo/platform/yui/compressor/CssCompressor.java
@@ -358,7 +358,7 @@ public class CssCompressor {
             for (i = 0; i < rgbcolors.length; i++) {
                 int val = Integer.parseInt(rgbcolors[i]);
                 if (val < 16) {
-                    hexcolor.append("0");
+                    hexcolor.append('0');
                 }
 
                 // If someone passes an RGB value that's too big to express in two characters, round down.