You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/27 01:07:45 UTC
[GitHub] [iceberg] HeartSaVioR opened a new pull request #1390: DOC: Move appendix in SSS doc to maintenance, add missing link
HeartSaVioR opened a new pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390
Appendix in SSS page was actually to deduplicate code in maintenance page, but it didn't move to maintenance page once we extract the content from SSS page.
I also add a link for compacting data files in SSS page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HeartSaVioR commented on pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#issuecomment-691757552
Thanks for reviewing and merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HeartSaVioR commented on a change in pull request #1390: DOC: Move appendix in SSS doc to maintenance, add missing link
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r478787281
##########
File path: site/docs/maintenance.md
##########
@@ -130,3 +130,25 @@ table.rewriteManifests()
See the [`RewriteManifestsAction` Javadoc](/javadoc/master/org/apache/iceberg/actions/RewriteManifestsAction.html) to see more configuration options.
+## Appendix
Review comment:
I feel there's a slight gap between content in `Create a table` in [java-api-quickstart](https://iceberg.apache.org/java-api-quickstart/#create-a-table) page and here, but it would be OK to just link the section if we think end users can infer they need to call `loadTable` instead. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HeartSaVioR commented on a change in pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r481505903
##########
File path: site/docs/java-api-quickstart.md
##########
@@ -41,6 +41,9 @@ import org.apache.iceberg.catalog.TableIdentifier;
TableIdentifier name = TableIdentifier.of("logging", "logs");
Table table = catalog.createTable(name, schema, spec);
+
+// or to load an existing table, use the following line
+// Table table = catalog.loadTable(name);
Review comment:
Ah yes I did this because having a new section for loading table would duplicate the code here. It'd be easier for us to have a different PR (or a PR against my fork) if you have better idea. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1390: DOC: Move appendix in SSS doc to maintenance, add missing link
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r478764321
##########
File path: site/docs/maintenance.md
##########
@@ -130,3 +130,25 @@ table.rewriteManifests()
See the [`RewriteManifestsAction` Javadoc](/javadoc/master/org/apache/iceberg/actions/RewriteManifestsAction.html) to see more configuration options.
+## Appendix
Review comment:
Do we need this here? It seems like we should link to the API sections that cover this instead of duplicating the content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r481331537
##########
File path: site/docs/java-api-quickstart.md
##########
@@ -41,6 +41,9 @@ import org.apache.iceberg.catalog.TableIdentifier;
TableIdentifier name = TableIdentifier.of("logging", "logs");
Table table = catalog.createTable(name, schema, spec);
+
+// or to load an existing table, use the following line
+// Table table = catalog.loadTable(name);
Review comment:
I think we should add a section for this instead of adding this block in multiple places. I'm happy to do that if you want to keep it separate from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1390: DOC: Move appendix in SSS doc to maintenance, add missing link
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r479426711
##########
File path: site/docs/maintenance.md
##########
@@ -130,3 +130,25 @@ table.rewriteManifests()
See the [`RewriteManifestsAction` Javadoc](/javadoc/master/org/apache/iceberg/actions/RewriteManifestsAction.html) to see more configuration options.
+## Appendix
Review comment:
I agree about the API quickstart. Now that Spark SQL supports DDL operations, we should start in that section with loading a table. At the top, we can point to the "Getting started" page with SQL create table and the section on creating tables, but after that talk about how to load tables with the API.
And linking to the quickstart is good for this, since we want to point to the right docs, not copy information. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HeartSaVioR commented on pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#issuecomment-684878998
I've changed the approach to point to Java quickstart page as suggested.
<img width="883" alt="Screen Shot 2020-09-01 at 11 01 31 PM" src="https://user-images.githubusercontent.com/1317309/91861084-60720480-eca7-11ea-9bdb-21d4c09d32f0.png">
<img width="865" alt="Screen Shot 2020-09-01 at 11 02 02 PM" src="https://user-images.githubusercontent.com/1317309/91861098-64058b80-eca7-11ea-97b3-a9358f0445f8.png">
Could you please take a look again? Thanks in advance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1390: DOC: Remove unnecessary appendix in SSS doc, add missing links
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#issuecomment-691743395
Thanks, @HeartSaVioR! I'm merging this and will follow up with a PR to better explain how to load a table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1390: DOC: Move appendix in SSS doc to maintenance, add missing link
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1390:
URL: https://github.com/apache/iceberg/pull/1390#discussion_r478764395
##########
File path: site/docs/spark-structured-streaming.md
##########
@@ -76,31 +76,9 @@ Each micro-batch written to a table produces a new snapshot, which are tracked i
### Compacting data files
-The amount of data written in a micro batch is typically small, which can cause the table metadata to track lots of small files. Compacting small files into larger files reduces the metadata needed by the table, and increases query efficiency.
+The amount of data written in a micro batch is typically small, which can cause the table metadata to track lots of small files. [Compacting small files into larger files](../maintenance#compact-data-files) reduces the metadata needed by the table, and increases query efficiency.
Review comment:
This looks good, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org