You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/04 01:50:37 UTC
[GitHub] [hive] aasha commented on a change in pull request #1467: HIVE-24117 : Fix for not setting managed table location in incrementa…
aasha commented on a change in pull request #1467:
URL: https://github.com/apache/hive/pull/1467#discussion_r483341397
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -1192,6 +1192,10 @@ private static void createReplImportTasks(
// have been already created when replaying previous events. So no need to create table
// again.
if (x.getEventType() != DumpType.EVENT_COMMIT_TXN) {
+ //Don't set location for managed tables while creating the table.
+ if (x.getEventType() == DumpType.EVENT_CREATE_TABLE && !tblDesc.isExternal()) {
Review comment:
For external table, we can still set location. Managed tables are hive managed. So this is not allowed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org