You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/02/06 15:13:16 UTC

[GitHub] spark pull request: [SPARK-5239][CORE]JdbcRDD throws "java.lang.Ab...

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/4033#issuecomment-73241705
  
    I take it back (see https://issues.apache.org/jira/browse/SPARK-5481) Yes, there's evidence of JDBC 3 drivers in the wild, still, and because I confirmed that `close()`ing these three objects is required to be a no-op if already closed, so, this really can't hurt.
    
    Similar changes should be made in `JDBCRDD.scala` in Spark SQL. Could you update the PR to address that too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org