You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Yan Fang (JIRA)" <ji...@apache.org> on 2015/09/15 00:51:45 UTC

[jira] [Commented] (SAMZA-771) Refactor supported metrics

    [ https://issues.apache.org/jira/browse/SAMZA-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744429#comment-14744429 ] 

Yan Fang commented on SAMZA-771:
--------------------------------

I looked at the code, you are correct. There are some duplicated code between SAMZA-340 and SAMZA-341. My opinion is that, since they are in different packages now, let's make each of them work first. Then consider to refactor to reduce the duplicated code.

In terms of the STDOUT and CSV, there is no need to use com.codahale.metrics.*, Samza's own metrics should be sufficient. So not in the scope of this refactoring.

> Refactor supported metrics 
> ---------------------------
>
>                 Key: SAMZA-771
>                 URL: https://issues.apache.org/jira/browse/SAMZA-771
>             Project: Samza
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Aleksandar Pejakovic
>            Assignee: Aleksandar Pejakovic
>            Priority: Minor
>              Labels: metrics
>             Fix For: 0.10.0
>
>
> In tickets [SAMZA-341|https://issues.apache.org/jira/browse/SAMZA-341] and [SAMZA-340|https://issues.apache.org/jira/browse/SAMZA-340] we add new module for metrics, samza-graphite and samza-ganglia. They have same core classes (timer, gauge, snapshot, counter). The difference is only in ReporterFactory and Reporter class. There are two more tickets that would have same core classes.
> I think we should make one module that contains core classes, and several small modules for every new metrics (Ganglia, Graphite, CSV, Console, ...).
> This ticket will cover [SAMZA-341|https://issues.apache.org/jira/browse/SAMZA-341], [SAMZA-340|https://issues.apache.org/jira/browse/SAMZA-340], [SAMZA-339|https://issues.apache.org/jira/browse/SAMZA-339] and [SAMZA-338|https://issues.apache.org/jira/browse/SAMZA-341].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)