[GitHub] [superset] benjreinhart commented on a change in pull request #14291: fix: Fix unintended cache misses with async queries

[GitBox <gi...@apache.org>]

benjreinhart commented on a change in pull request #14291:
URL: https://github.com/apache/superset/pull/14291#discussion_r618633326



##########
File path: superset/utils/core.py
##########
@@ -1065,6 +1065,9 @@ def to_adhoc(
     elif expression_type == "SQL":
         result.update({"sqlExpression": filt.get(clause)})
 
+    deterministic_name = md5_sha_from_dict(result)
+    result["filterOptionName"] = deterministic_name

Review comment:
       Yeah, I agree we should get some 👀 on this from folks more familiar. AFAICT, this preserves the existing behavior of generating a unique key (which I assume is needed on clients) but also keeps it deterministic so that hashing `form_data` for will work properly (both with async/non-async caching).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org