You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@giraph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/22 19:23:00 UTC

[jira] [Commented] (GIRAPH-1172) Remove Findbugs dependency with incompatible license.

    [ https://issues.apache.org/jira/browse/GIRAPH-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373280#comment-16373280 ] 

ASF GitHub Bot commented on GIRAPH-1172:
----------------------------------------

GitHub user jdasch opened a pull request:

    https://github.com/apache/giraph/pull/61

    GIRAPH-1172 Removed dependency com.google.code.findbugs:annotations

    Replaced `com.google.code.findbugs:annotations:2.0.2` with `com.github.stephenc.findbugs:findbugs-annotations:1.3.9-1` and `com.google.code.findbugs:jsr305:2.0.2`.
    
    Had to remove a couple annotations that don't exist in the older version of the drop-in replacement.  There is a newer version of com.github.stephenc.findbugs:findbugs-annotations, but it hasn't been uploaded to maven central for some reason.  Moved usage of those annotations to the findbugs-exclude.xml file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdasch/giraph GIRAPH-1172

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/giraph/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit b551367c6d1bf4522323b7678c6eca95555b153f
Author: jdasch <hc...@...>
Date:   2018-02-20T19:01:49Z

    GIRAPH-1172 Removed dependency com.google.code.findbugs:annotations

----


> Remove Findbugs dependency with incompatible license.
> -----------------------------------------------------
>
>                 Key: GIRAPH-1172
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1172
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Jeff Dasch
>            Priority: Major
>             Fix For: 1.3.0
>
>
> The dependency com.google.code.findbugs:annotations:jar:2.0.2 has an incompatible LGPL license and needs to be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)