You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/04/20 15:12:31 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #297: =act Make PipeableCompletionStage an AnyVal.
He-Pin opened a new pull request, #297:
URL: https://github.com/apache/incubator-pekko/pull/297
Motivation:
Make it an `AnyVal` when it could.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #297: =act Make PipeableCompletionStage an AnyVal.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #297: =act Make PipeableCompletionStage an AnyVal.
URL: https://github.com/apache/incubator-pekko/pull/297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #297: =act Make PipeableCompletionStage an AnyVal.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #297:
URL: https://github.com/apache/incubator-pekko/pull/297#discussion_r1172744505
##########
actor/src/main/scala/org/apache/pekko/pattern/PipeToSupport.scala:
##########
@@ -53,36 +53,6 @@ trait PipeToSupport {
}
}
- final class PipeableCompletionStage[T](val future: CompletionStage[T])(
- implicit @unused executionContext: ExecutionContext) {
Review Comment:
`executionContext` was never used, by dropping it we can make `PipeableCompletionStage` an `AnyVal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org