You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/20 09:10:03 UTC

[PR] fix(dlq): drop the always-zero retry count from the CSV export [rocketmq-dashboard]

zjncs opened a new pull request, #7254:
URL: https://github.com/apache/rocketmq-dashboard/pull/7254

   ## Problem
   
   The DLQ CSV export carries a `Retry Count` column (`web/src/pages/instance/dlq.tsx:74`), but the only `DLQGroupVO` producer hardcodes `.retryCount(0)` for every group (`RocketMQDLQProvider.java:186`; grep confirms no other producer). Every row of every exported CSV claims `Retry Count 0` regardless of the group's actual retry activity — misleading data an operator may use to triage dead-letter severity. A true count needs per-message `reconsumeTimes`, which the provider does not fetch.
   
   ## Fix
   
   Remove the always-zero column from the export column list. Nothing else on the page consumes `retryCount`.
   
   ## Verification
   
   - New regression test in `DLQPage.test.tsx` first: RED — header contained `Retry Count`; GREEN after the fix — 40/40 pass (`npx vitest run DLQPage.test.tsx`).
   - `eslint` on the touched file: 0 errors (1 pre-existing react-refresh warning). `tsc -b --noEmit`: exit 0.
   
   ## Risk / conflict disclosure
   
   Behavior change is deliberately narrow: the CSV loses a column that was constant zero. Several open PRs touch `dlq.tsx` (none touch the export columns); happy to rebase if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): drop the always-zero retry count from the CSV export [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #7254:
URL: https://github.com/apache/rocketmq-dashboard/pull/7254#issuecomment-6618835629

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): drop the always-zero retry count from the CSV export [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #7254: fix(dlq): drop the always-zero retry count from the CSV export
URL: https://github.com/apache/rocketmq-dashboard/pull/7254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org