You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dependabot@commons.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/09/13 08:38:11 UTC
[PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
dependabot[bot] opened a new pull request, #90:
URL: https://github.com/apache/commons-secure-xml/pull/90
Bumps com.android.library from 8.6.1 to 9.4.0.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dependabot-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #90:
URL: https://github.com/apache/commons-secure-xml/pull/90#issuecomment-5653985649
Rebased on `main` (which already carries the JUnit 5 plugin bumps from #92/#93) and pushed the AGP 9 DSL migration: `testOptions.managedDevices.devices` is gone in AGP 9, so the managed device is declared through the typed `localDevices` container.
What is still missing is on the AGP side. Same tests, same JUnit 5 plugin (2.0.1), same emulator:
| | tests | failures | skipped |
|---|---|---|---|
| AGP 8.6.1 (`main`) | 259 | 0 | 87 |
| AGP 9.4.0 (this PR) | 259 | 87 | 0 |
The 87 are JUnit 5 assumption aborts (`TestAbortedException`) — platform-dependent skips such as *"platform DOM does not resolve user-defined entities"*. The device-side invocation is identical in both runs; only the host-side result handling differs. AGP 8 wrote a per-suite `TEST-<device>-_-.xml` with `skipped="87"`, AGP 9 aggregates through its `com.android.junit.engine.*` plumbing into a single `<testsuites>` file with `failures="87"`.
**1. Keeping `de.mannodermaus.android-junit5`**, we need AGP 9 to:
- record an aborted JUnit 5 test as skipped rather than failed;
- tolerate (or drop) an instrumentation argument with an empty value. The plugin passes `-e configurationParameters ` with nothing after it, `am instrument` then reads the following key as the component name and fails with `No instrumentation found for: de.mannodermaus.junit.unsupported.behavior`, so zero tests run and the JaCoCo task dies on the empty execution data with `Invalid execution data file`. Worked around in this PR by giving that argument a value; it could equally be fixed on the plugin side.
**2. Migrating to AGP's own JUnit 5 support**, we would need:
- a device-side Jupiter engine. Dropping the plugin today yields `tests="0"`: the `com.android.junit.engine.*` properties AGP 9 passes are host-side result plumbing, not an on-device engine;
- tag filtering equivalent to `junitPlatform { filters { includeTags("dom | sax | schema | trax") } }`, which this module uses to skip the JAXP groups Android does not ship;
- the Jupiter artifacts to package without a hand-written `packaging.resources.excludes`, since `mergeDebugAndroidTestJavaResource` otherwise fails on `META-INF/LICENSE.md` duplicated across `junit-platform-engine`, `junit-platform-commons` and `junit-jupiter-engine`;
- the same skipped-not-failed reporting as in 1.
Until the first point of 1 is fixed upstream, CI on this branch stays red on those 87 phantom failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #90:
URL: https://github.com/apache/commons-secure-xml/pull/90#issuecomment-5653997248
Correction to my previous comment: the 87 aborts do **not** fail the build. `connectedDebugAndroidTest` — the task CI runs — reports BUILD SUCCESSFUL under AGP 9.4.0 exactly as it does under AGP 8.6.1, and CI here is green. I read `failures="87"` out of the result XML and wrote "stays red" without checking Gradle's own outcome.
What is actually different is the report AGP 9 writes and the job uploads: the 87 JUnit 5 assumption aborts are recorded as failures there, where AGP 8.6.1 recorded them as skips. So the migration is not blocked; what we would still want from AGP 9 is that its aggregated test XML label an aborted test as skipped, so the uploaded reports — and anything that parses them — do not read 87 phantom failures.
The two lists in the previous comment stand otherwise, with the first item of case 1 downgraded from a blocker to a reporting defect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #90:
URL: https://github.com/apache/commons-secure-xml/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #90:
URL: https://github.com/apache/commons-secure-xml/pull/90#discussion_r4000233479
##########
android-tests/build.gradle.kts:
##########
@@ -61,6 +62,8 @@ android {
minSdk = 26
// androidx.test runner; Mannodermaus's android-junit5 plugin slots a JUnit 5 RunnerBuilder under it so AndroidJUnitRunner picks up Jupiter tests.
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+ // The plugin passes an empty configurationParameters argument, which am instrument mis-parses; give it a value.
Review Comment:
This comment is gibberish: "which am instrument mis-parses; give it a value"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump com.android.library from 8.6.1 to 9.4.0 in /android-tests [commons-secure-xml]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #90:
URL: https://github.com/apache/commons-secure-xml/pull/90#discussion_r4000402878
##########
android-tests/build.gradle.kts:
##########
@@ -61,6 +62,8 @@ android {
minSdk = 26
// androidx.test runner; Mannodermaus's android-junit5 plugin slots a JUnit 5 RunnerBuilder under it so AndroidJUnitRunner picks up Jupiter tests.
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+ // The plugin passes an empty configurationParameters argument, which am instrument mis-parses; give it a value.
Review Comment:
Fixed in https://github.com/apache/commons-secure-xml/pull/90/commits/b4bdcee10ad1d367e2bb5a10ade73d6569fe115d together with a concrete example of what is going on.
This is a bug report for `android-junit-framework` we should file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org