You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by elliotttf <gi...@git.apache.org> on 2018/07/03 17:36:46 UTC

[GitHub] tinkerpop pull request #888: fix(DriverRemoteConnection): return the promise...

GitHub user elliotttf opened a pull request:

    https://github.com/apache/tinkerpop/pull/888

    fix(DriverRemoteConnection): return the promise on close

    This replaces #887.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elliotttf/tinkerpop fix-close-return-tp32

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #888
    
----
commit f6e50ae231ebd6cf9e488522967ad1d483de4781
Author: Elliott Foster <el...@...>
Date:   2018-07-03T17:35:55Z

    fix(DriverRemoteConnection): return the promise on close

----


---

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/888
  
    Thanks for changing the base branch @elliotttf 
    
    Looks good, VOTE +1


---

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/888
  
    As this is a straightforward bug fix, I think its ok to do a CTR and avoid waiting for an additional review/vote.


---

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/888
  
    Sure - looks that way to me.  Please add a changelog entry when you merge.


---

[GitHub] tinkerpop pull request #888: TINKERPOP-1995 Return the Promise on Close

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/888


---

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/888
  
    VOTE +1


---