You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/10/29 08:51:18 UTC

[PR] [refine](function) Remove mutable variables in the function [doris]

Mryange opened a new pull request, #42854:
URL: https://github.com/apache/doris/pull/42854

   ## Proposed changes
   
    Remove mutable variables in the function. If state is needed within the function, 
    it should be placed in FunctionContext.
   
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2444513629

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #42854: [refine](function) Remove mutable variables in the function
URL: https://github.com/apache/doris/pull/42854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2444107858

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2443613659

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2445509463

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2445535084

   TeamCity be ut coverage result:
    Function Coverage: 37.68% (9773/25934) 
    Line Coverage: 28.76% (80707/280614)
    Region Coverage: 28.19% (41731/148032)
    Branch Coverage: 24.72% (21177/85668)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/1340b3fa3175759cff9380e82040476aa36e2c26_1340b3fa3175759cff9380e82040476aa36e2c26/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2451667361

   TeamCity be ut coverage result:
    Function Coverage: 37.80% (9818/25973) 
    Line Coverage: 28.99% (81626/281549)
    Region Coverage: 28.26% (42137/149121)
    Branch Coverage: 24.84% (21381/86076)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b1d47e7053e4d5595a613e89b148565be1d87919_b1d47e7053e4d5595a613e89b148565be1d87919/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2443603236

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2451541904

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2446009544

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2445513795

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2444526715

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2458674638

   TeamCity be ut coverage result:
    Function Coverage: 37.84% (9833/25984) 
    Line Coverage: 29.03% (81811/281857)
    Region Coverage: 28.26% (42148/149159)
    Branch Coverage: 24.84% (21384/86098)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b1d47e7053e4d5595a613e89b148565be1d87919_b1d47e7053e4d5595a613e89b148565be1d87919/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2446004198

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2461236353

   TeamCity be ut coverage result:
    Function Coverage: 37.87% (9847/26000) 
    Line Coverage: 29.03% (81876/282034)
    Region Coverage: 28.26% (42179/149240)
    Branch Coverage: 24.84% (21398/86142)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b1d47e7053e4d5595a613e89b148565be1d87919_b1d47e7053e4d5595a613e89b148565be1d87919/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2443603521

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2444097741

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2453942289

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2458577370

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2454111636

   TeamCity be ut coverage result:
    Function Coverage: 37.80% (9819/25976) 
    Line Coverage: 28.97% (81650/281817)
    Region Coverage: 28.22% (42100/149189)
    Branch Coverage: 24.80% (21360/86138)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b1d47e7053e4d5595a613e89b148565be1d87919_b1d47e7053e4d5595a613e89b148565be1d87919/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2446196491

   TeamCity be ut coverage result:
    Function Coverage: 37.95% (9845/25945) 
    Line Coverage: 29.22% (82002/280628)
    Region Coverage: 28.56% (42287/148039)
    Branch Coverage: 25.09% (21489/85658)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/780590115ee7158a0e875d3c514abe95cc3f795e_780590115ee7158a0e875d3c514abe95cc3f795e/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2451548074

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2461159208

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](function) Remove mutable variables in the function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42854:
URL: https://github.com/apache/doris/pull/42854#issuecomment-2444251414

   TeamCity be ut coverage result:
    Function Coverage: 37.68% (9771/25934) 
    Line Coverage: 28.74% (80656/280614)
    Region Coverage: 28.19% (41725/148032)
    Branch Coverage: 24.72% (21177/85668)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/01abc2882bd0fe834346c1293d9136b9cd291b2c_01abc2882bd0fe834346c1293d9136b9cd291b2c/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org