You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by vbnhfylbh <gi...@git.apache.org> on 2017/08/09 10:16:05 UTC
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
GitHub user vbnhfylbh opened a pull request:
https://github.com/apache/cxf/pull/305
Fix of non thread safe map reqHeaders
SOAP_ACTION is shared between different requests despite thread.local.request.context=true. Reproduced under load of 100 transactions per second.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vbnhfylbh/cxf soapAction-threadsafe-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
Posted by vbnhfylbh <gi...@git.apache.org>.
GitHub user vbnhfylbh reopened a pull request:
https://github.com/apache/cxf/pull/305
Fix of non thread safe map reqHeaders
SOAP_ACTION is shared between different requests despite thread.local.request.context=true. Reproduced under load of 100 transactions per second.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vbnhfylbh/cxf soapAction-threadsafe-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
commit 74aa06d76a61e40be2b0a99725df1ce16861fec5
Author: Dmitry Panov <vb...@gmail.com>
Date: 2017-08-09T09:59:59Z
Fix of non thread safe map reqHeaders - SOAP_ACTION is shared between different requests despite thread.local.request.context=true. Reproduced under load of 100 transactions per second.
commit 4648bd3dcc3fd77b0b0e18540683deb52f8c7be6
Author: Dmitry Panov <vb...@gmail.com>
Date: 2017-08-29T08:50:08Z
fix star imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
Posted by vbnhfylbh <gi...@git.apache.org>.
Github user vbnhfylbh closed the pull request at:
https://github.com/apache/cxf/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #305: Fix of non thread safe map reqHeaders
Posted by vbnhfylbh <gi...@git.apache.org>.
Github user vbnhfylbh commented on the issue:
https://github.com/apache/cxf/pull/305
@deki, thanks for your feedback. Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/305#discussion_r134758330
--- Diff: rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/SoapPreProtocolOutInterceptor.java ---
@@ -19,24 +19,16 @@
package org.apache.cxf.binding.soap.interceptor;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.TreeMap;
-
-import org.apache.cxf.binding.soap.Soap11;
-import org.apache.cxf.binding.soap.Soap12;
-import org.apache.cxf.binding.soap.SoapBindingConstants;
-import org.apache.cxf.binding.soap.SoapMessage;
-import org.apache.cxf.binding.soap.SoapVersion;
+import org.apache.cxf.binding.soap.*;
--- End diff --
please avoid star imports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #305: Fix of non thread safe map reqHeaders
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/305
Looks like you need to rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
Posted by vbnhfylbh <gi...@git.apache.org>.
Github user vbnhfylbh closed the pull request at:
https://github.com/apache/cxf/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #305: Fix of non thread safe map reqHeaders
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/305#discussion_r134758370
--- Diff: rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/SoapPreProtocolOutInterceptor.java ---
@@ -19,24 +19,16 @@
package org.apache.cxf.binding.soap.interceptor;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.TreeMap;
-
-import org.apache.cxf.binding.soap.Soap11;
-import org.apache.cxf.binding.soap.Soap12;
-import org.apache.cxf.binding.soap.SoapBindingConstants;
-import org.apache.cxf.binding.soap.SoapMessage;
-import org.apache.cxf.binding.soap.SoapVersion;
+import org.apache.cxf.binding.soap.*;
import org.apache.cxf.binding.soap.model.SoapOperationInfo;
import org.apache.cxf.helpers.CastUtils;
import org.apache.cxf.interceptor.Fault;
import org.apache.cxf.message.Message;
import org.apache.cxf.phase.Phase;
import org.apache.cxf.service.model.BindingOperationInfo;
+import java.util.*;
--- End diff --
please avoid star imports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #305: Fix of non thread safe map reqHeaders
Posted by vbnhfylbh <gi...@git.apache.org>.
Github user vbnhfylbh commented on the issue:
https://github.com/apache/cxf/pull/305
Thanks for your feedback. Created https://github.com/apache/cxf/pull/306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---