[jira] [Commented] (GUACAMOLE-936) Leaked LdapNetworkConnection prevents Tomcat shutdown

["Mike Jumper (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022733#comment-17022733 ] 

Mike Jumper commented on GUACAMOLE-936:
---------------------------------------

Looks like there's another leak within the referral following code. The {{bindAs()}} calls were easy enough to verify, but there was a direct call to {{new LdapNetworkConnection(...)}} hiding in the referral handling.

> Leaked LdapNetworkConnection prevents Tomcat shutdown
> -----------------------------------------------------
>
>                 Key: GUACAMOLE-936
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-936
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-auth-ldap
>    Affects Versions: 1.1.0
>            Reporter: Mike Jumper
>            Assignee: Mike Jumper
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> Within the LDAP support, the {{LdapNetworkConnection}} from the bind attempt used to authenticate the Guacamole is never closed. As the socket implementation used by the Apache Directory API ultimately uses a {{ThreadPoolExecutor}} to facilitate non-blocking I/O, this leaks a thread which prevents Tomcat from shutting down.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)