[GitHub] [airflow] ephraimbuddy commented on pull request #25594: Fix mapped sensor with reschedule mode

[GitBox <gi...@apache.org>]

ephraimbuddy commented on PR #25594:
URL: https://github.com/apache/airflow/pull/25594#issuecomment-1209255782

   > > MappedOperator does not have the `ReadyToReschedule` dependency.
   > 
   > Hmm, I am not sure putting ReadyToReschedule in BaseOperator is a good idea. Why is this needed though? MappedOperator reads `deps` when the wrapped class calls `expand`, so when you do `Sensor.expand()`, the resulting MappedOperator should automatically contain ReadyToReschedule. Is this dep lost somewhere in the scheduler?
   
   Figured and fixed the `deps` part and added a test for the reserialization. There seems to be a problem in mapped op serialization which I think will affect other custom operators that added extra serializable fields. Once it's fixed for the sensor, it'll be fixed for all. For now, the logic is still in reschedule dep check for the reschedule attribute


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org