You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flume.apache.org by es...@apache.org on 2011/08/12 02:46:55 UTC
svn commit: r1156879 -
/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java
Author: esammer
Date: Fri Aug 12 00:46:55 2011
New Revision: 1156879
URL: http://svn.apache.org/viewvc?rev=1156879&view=rev
Log:
- Added a note about error handling and ordering of operations.
Modified:
incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java
Modified: incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java
URL: http://svn.apache.org/viewvc/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java?rev=1156879&r1=1156878&r2=1156879&view=diff
==============================================================================
--- incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java (original)
+++ incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/core/ChannelDriver.java Fri Aug 12 00:46:55 2011
@@ -166,6 +166,13 @@ public class ChannelDriver implements Li
lifecycleState = LifecycleState.START;
+ /*
+ * Developer note: We purposefully separate source and sink open and close
+ * try / catch blocks so we can provide slightly better error messaging
+ * and recovery. Please resist the urge to combine them. The ordering of
+ * sink open, source open, source close, sink close is deliberate as well.
+ */
+
try {
sink.open(context);
} catch (InterruptedException e) {