You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/12/03 12:01:58 UTC
[jira] [Commented] (BOOKKEEPER-205) implement a MetaStore based
ledger manager for bookkeeper client.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508645#comment-13508645 ]
Ivan Kelly commented on BOOKKEEPER-205:
---------------------------------------
I'm not sure about this patch. It creates another variant for tests, which will increase the test time by 50%. They already take too long. For this reason, I'd like get BOOKKEEPER-474 and BOOKKEEPER-475 in before this one goes in.
In terms of code, generally it looks fine. I'd rename MetastoreClass to MetastoreImplementationClass or MetastoreImplClass. Also, the javadoc should mention that the configuration options are only used it Metastore ledger manager is enabled in the other config items.
Also, there's a failing test in the precommit build, and something went in recently which is messing with the patch application.
> implement a MetaStore based ledger manager for bookkeeper client.
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-205
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-205
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Reporter: Sijie Guo
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-205.diff
>
>
> implement a MetaStore based ledger manager for bookkeeper client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira