You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "Stephane Bailliez (JIRA)" <ji...@apache.org> on 2007/01/07 14:24:27 UTC
[jira] Created: (IVY-375) Refactoring / documentation / test of
matcher package
Refactoring / documentation / test of matcher package
-----------------------------------------------------
Key: IVY-375
URL: https://issues.apache.org/jira/browse/IVY-375
Project: Ivy
Issue Type: Improvement
Components: Core
Affects Versions: 1.4.1
Reporter: Stephane Bailliez
Priority: Trivial
Attachments: matcher-src.patch
Objective was to cleanup slightly the code by documenting the exact intent of the interface and methods to provide a consistent implementation. Implementation has been adjusted to match it:
- Does not support null input
- Does not support null expression
- Remove getInstance() method in favor of INSTANCE public static final field.
- Remove unused method
- Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome was not made in a day
- Added testcases for all pattern matchers
- Added // TODO notes for long-term mental notes
The change is overall minor and have little impact to the rest of the code.
I expect some slight API adjustements later on but this is enough for now.
Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (IVY-375) Refactoring / documentation / test of
matcher package
Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier Hanin reassigned IVY-375:
--------------------------------
Assignee: Xavier Hanin
> Refactoring / documentation / test of matcher package
> -----------------------------------------------------
>
> Key: IVY-375
> URL: https://issues.apache.org/jira/browse/IVY-375
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.4.1
> Reporter: Stephane Bailliez
> Assigned To: Xavier Hanin
> Priority: Trivial
> Attachments: matcher-src.patch, matcher-test.patch
>
>
> Objective was to cleanup slightly the code by documenting the exact intent of the interface and methods to provide a consistent implementation. Implementation has been adjusted to match it:
> - Does not support null input
> - Does not support null expression
> - Remove getInstance() method in favor of INSTANCE public static final field.
> - Remove unused method
> - Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome was not made in a day
> - Added testcases for all pattern matchers
> - Added // TODO notes for long-term mental notes
> The change is overall minor and have little impact to the rest of the code.
> I expect some slight API adjustements later on but this is enough for now.
> Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (IVY-375) Refactoring / documentation / test of
matcher package
Posted by "Stephane Bailliez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Bailliez updated IVY-375:
----------------------------------
Attachment: matcher-src.patch
> Refactoring / documentation / test of matcher package
> -----------------------------------------------------
>
> Key: IVY-375
> URL: https://issues.apache.org/jira/browse/IVY-375
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.4.1
> Reporter: Stephane Bailliez
> Priority: Trivial
> Attachments: matcher-src.patch
>
>
> Objective was to cleanup slightly the code by documenting the exact intent of the interface and methods to provide a consistent implementation. Implementation has been adjusted to match it:
> - Does not support null input
> - Does not support null expression
> - Remove getInstance() method in favor of INSTANCE public static final field.
> - Remove unused method
> - Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome was not made in a day
> - Added testcases for all pattern matchers
> - Added // TODO notes for long-term mental notes
> The change is overall minor and have little impact to the rest of the code.
> I expect some slight API adjustements later on but this is enough for now.
> Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (IVY-375) Refactoring / documentation / test of
matcher package
Posted by "Stephane Bailliez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Bailliez updated IVY-375:
----------------------------------
Attachment: matcher-test.patch
> Refactoring / documentation / test of matcher package
> -----------------------------------------------------
>
> Key: IVY-375
> URL: https://issues.apache.org/jira/browse/IVY-375
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.4.1
> Reporter: Stephane Bailliez
> Priority: Trivial
> Attachments: matcher-src.patch, matcher-test.patch
>
>
> Objective was to cleanup slightly the code by documenting the exact intent of the interface and methods to provide a consistent implementation. Implementation has been adjusted to match it:
> - Does not support null input
> - Does not support null expression
> - Remove getInstance() method in favor of INSTANCE public static final field.
> - Remove unused method
> - Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome was not made in a day
> - Added testcases for all pattern matchers
> - Added // TODO notes for long-term mental notes
> The change is overall minor and have little impact to the rest of the code.
> I expect some slight API adjustements later on but this is enough for now.
> Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (IVY-375) Refactoring / documentation / test of
matcher package
Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xavier Hanin resolved IVY-375.
------------------------------
Resolution: Fixed
Fix Version/s: 1.5
I've integrated your patch, very good job! I like your code style, very clean.
The only thing I modified is fix a NPE introduced by the new clean way to deal with null input consistently, which threw a NPE in the Ivy.listModules method when there is no branch. Not a big deal.
Thanks a lot for your contribution.
> Refactoring / documentation / test of matcher package
> -----------------------------------------------------
>
> Key: IVY-375
> URL: https://issues.apache.org/jira/browse/IVY-375
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.4.1
> Reporter: Stephane Bailliez
> Assigned To: Xavier Hanin
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: matcher-src.patch, matcher-test.patch
>
>
> Objective was to cleanup slightly the code by documenting the exact intent of the interface and methods to provide a consistent implementation. Implementation has been adjusted to match it:
> - Does not support null input
> - Does not support null expression
> - Remove getInstance() method in favor of INSTANCE public static final field.
> - Remove unused method
> - Javadoc documentation where appropriate (it's not full-fledged, but eh.. Rome was not made in a day
> - Added testcases for all pattern matchers
> - Added // TODO notes for long-term mental notes
> The change is overall minor and have little impact to the rest of the code.
> I expect some slight API adjustements later on but this is enough for now.
> Let me know if there are issues and if I forgot something in the patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira