You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/05/29 21:27:16 UTC

Review Request 59633: Create .md files to describe Log Search input configurations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59633/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21144
    https://issues.apache.org/jira/browse/AMBARI-21144


Repository: ambari


Description
-------

Create .md files to describe Log Search input configurations


Diffs
-----

  ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/inputConfig.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java 5d34c06 


Diff: https://reviews.apache.org/r/59633/diff/1/


Testing
-------

Nothing to test


Thanks,

Miklos Gergely


Re: Review Request 59633: Create .md files to describe Log Search input configurations

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59633/#review176303
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On May 30, 2017, 1:48 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59633/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21144
>     https://issues.apache.org/jira/browse/AMBARI-21144
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create .md files to describe Log Search input configurations
> 
> Also removed unused input parameter start_position
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java c41da93 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputDescriptorImpl.java 94dcc2a 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapDateDescriptorImpl.java 9daad2b 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md d00eb57 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/inputConfig.md PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java cfa1903 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java 5d34c06 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java 3a5f31e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/samples/config/config_audit.json b7d0a6e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/samples/config/config_service.json 2e96fd7 
>   ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInput.java e0f7564 
>   ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapDate.java 3147402 
>   ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 7ac29dd 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2 f337527 
> 
> 
> Diff: https://reviews.apache.org/r/59633/diff/2/
> 
> 
> Testing
> -------
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 59633: Create .md files to describe Log Search input configurations

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59633/
-----------------------------------------------------------

(Updated May 30, 2017, 1:48 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

fixed minor issues in the documentation + removed unused parameter start_position


Bugs: AMBARI-21144
    https://issues.apache.org/jira/browse/AMBARI-21144


Repository: ambari


Description (updated)
-------

Create .md files to describe Log Search input configurations

Also removed unused input parameter start_position


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java c41da93 
  ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputDescriptorImpl.java 94dcc2a 
  ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapDateDescriptorImpl.java 9daad2b 
  ambari-logsearch/ambari-logsearch-logfeeder/README.md d00eb57 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/inputConfig.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md PRE-CREATION 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java cfa1903 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java 5d34c06 
  ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java 3a5f31e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/samples/config/config_audit.json b7d0a6e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/samples/config/config_service.json 2e96fd7 
  ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInput.java e0f7564 
  ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapDate.java 3147402 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 7ac29dd 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2 f337527 


Diff: https://reviews.apache.org/r/59633/diff/2/

Changes: https://reviews.apache.org/r/59633/diff/1-2/


Testing (updated)
-------

Tested on local cluster


Thanks,

Miklos Gergely