You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/05/31 10:50:32 UTC
Review Request 59525: Added filtering of roles in the endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/
-----------------------------------------------------------
Review request for mesos, Adam B and Greg Mann.
Bugs: MESOS-7416
https://issues.apache.org/jira/browse/MESOS-7416
Repository: mesos
Description
-------
Added filtering of roles in the endpoint.
Diffs
-----
src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
Diff: https://reviews.apache.org/r/59525/diff/1/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 59525: Added filtering of roles in the endpoint.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review176433
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59453, 58955, 58964, 59099, 59100, 59101, 59147, 59525]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 31, 2017, 12:50 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 12:50 p.m.)
>
>
> Review request for mesos, Adam B and Greg Mann.
>
>
> Bugs: MESOS-7416
> https://issues.apache.org/jira/browse/MESOS-7416
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added filtering of roles in the endpoint.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
>
>
> Diff: https://reviews.apache.org/r/59525/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 59525: Added filtering of `/slaves` endpoint and
`GET_AGENTS` API call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review176443
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59453, 58955, 58964, 59099, 59100, 59101, 59147, 59525]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 31, 2017, 12:41 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 12:41 p.m.)
>
>
> Review request for mesos, Adam B and Greg Mann.
>
>
> Bugs: MESOS-7416
> https://issues.apache.org/jira/browse/MESOS-7416
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds support of the `VIEW_ROLE` ACL to the results generated by
> the `/slaves` as well as the `GET_AGENTS` API v1 call. This means
> that calls to this endpoint (API call) will hide roles that the
> user making the request is not authorized to see.
>
>
> Diffs
> -----
>
> src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
>
>
> Diff: https://reviews.apache.org/r/59525/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 59525: Added filtering of `/slaves` endpoint and
`GET_AGENTS` API call.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/
-----------------------------------------------------------
(Updated May 31, 2017, 2:41 p.m.)
Review request for mesos, Adam B and Greg Mann.
Summary (updated)
-----------------
Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.
Bugs: MESOS-7416
https://issues.apache.org/jira/browse/MESOS-7416
Repository: mesos
Description (updated)
-------
Adds support of the `VIEW_ROLE` ACL to the results generated by
the `/slaves` as well as the `GET_AGENTS` API v1 call. This means
that calls to this endpoint (API call) will hide roles that the
user making the request is not authorized to see.
Diffs (updated)
-----
src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
Diff: https://reviews.apache.org/r/59525/diff/2/
Changes: https://reviews.apache.org/r/59525/diff/1-2/
Testing
-------
make check
Thanks,
Alexander Rojas