You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/31 14:05:19 UTC
[GitHub] [superset] villebro opened a new pull request #19464: fix(welcome): saved queries causing error
villebro opened a new pull request #19464:
URL: https://github.com/apache/superset/pull/19464
### SUMMARY
A recent PR #19223 caused a regression due to trying to query for `saved_query` objects by their owners, despite the model only having a creator (there is no `saved_query_user`, like there is for `dashboard_user` for `dashboards` and `slice_user` for `slices`). This renames the `getUserOwnedObjects` to `getUserObjects` and adds a parameter `filterBy` which makes it possible to define whether or not to query by `owners` or `created_by`.
### AFTER
After the change, the welcome page loads without errors:
<img width="1660" alt="image" src="https://user-images.githubusercontent.com/33317356/161073736-38973eaf-5fa7-45ae-874a-17fa82042986.png">
### BEFORE
Previously there was an error toast caused by a 400:
<img width="1667" alt="image" src="https://user-images.githubusercontent.com/33317356/161073889-44bf0d17-9b21-4890-87f9-f18bec634c3c.png">
### TESTING INSTRUCTIONS
1. Go to welcome page
2. Verify that the error no longer happens
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed pull request #19464: fix(welcome): saved queries causing error
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #19464:
URL: https://github.com/apache/superset/pull/19464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19464: fix(welcome): saved queries causing error
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #19464:
URL: https://github.com/apache/superset/pull/19464#issuecomment-1084638023
Closing as this is a duplicate of #19372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org