You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:52:24 UTC
[GitHub] [couchdb-helm] emcellsoft opened a new pull request, #100: Fefault value for ingress.annotations is now {}
emcellsoft opened a new pull request, #100:
URL: https://github.com/apache/couchdb-helm/pull/100
Fixes a warning when overriding ingress.annotations.
#### What this PR does / why we need it:
overriding ingress.annotations in my application produced a warning when using helm.
```
coalesce.go:223: warning: destination for couch.couchdb.ingress.annotations is a table. Ignoring non-table value ([])
coalesce.go:223: warning: destination for couch.couchdb.ingress.annotations is a table. Ignoring non-table value ([])
coalesce.go:223: warning: destination for couch.couchdb.ingress.annotations is a table. Ignoring non-table value ([])
```
ingress.annotations should be a map and not an array
#### Special notes for your reviewer:
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [ ] Chart Version bumped
- [ ] e2e tests pass
- [ ] Variables are documented in the README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] emcellsoft commented on pull request #100: Default value for ingress.annotations is now {}
Posted by "emcellsoft (via GitHub)" <gi...@apache.org>.
emcellsoft commented on PR #100:
URL: https://github.com/apache/couchdb-helm/pull/100#issuecomment-1448297515
Sorry, missed that. I have bumped the version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley merged pull request #100: Default value for ingress.annotations is now {}
Posted by "willholley (via GitHub)" <gi...@apache.org>.
willholley merged PR #100:
URL: https://github.com/apache/couchdb-helm/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #100: Default value for ingress.annotations is now {}
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #100:
URL: https://github.com/apache/couchdb-helm/pull/100#issuecomment-1373913100
@emcellsoft can you bump the chart version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] drazvan91 commented on pull request #100: Default value for ingress.annotations is now {}
Posted by "drazvan91 (via GitHub)" <gi...@apache.org>.
drazvan91 commented on PR #100:
URL: https://github.com/apache/couchdb-helm/pull/100#issuecomment-1448282940
@emcellsoft , @willholley , the issue is still there. The default should be {} instead of []. Can we bump the chart version and push the chart?
@willholley , I can make a pull request myself if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org