You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2007/07/11 08:17:04 UTC
[jira] Created: (GERONIMO-3307) persistence units in other modules
should not be picked up by PersistenceUnitDeployer called from a module
persistence units in other modules should not be picked up by PersistenceUnitDeployer called from a module
----------------------------------------------------------------------------------------------------------
Key: GERONIMO-3307
URL: https://issues.apache.org/jira/browse/GERONIMO-3307
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: persistence
Affects Versions: 2.0-M6
Reporter: David Jencks
Assignee: David Jencks
Fix For: 2.0-M7
We have some code that's supposed to prevent the PersistenceUntiBuilder from finding a persistence unit in another module, but it doesn't work if the module calling the persistenceUnitBuilder is a war in an ear. For wars, we have to prepend the path to the persistence unit with ../ since the war is a directory not a jar inside the car, and that no longer matches a module path. We can do two resotutions... one against the module path, once against the ../ and check for another module against the module-path-resolved uri.
This could use some unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-3307) persistence units in other modules
should not be picked up by PersistenceUnitDeployer called from a module
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-3307.
----------------------------------
Resolution: Fixed
Well, when I started writing unit tests I found a lot of problems. I think it all works now.
rev 555869 and 555871.
> persistence units in other modules should not be picked up by PersistenceUnitDeployer called from a module
> ----------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3307
> URL: https://issues.apache.org/jira/browse/GERONIMO-3307
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: persistence
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.0-M7
>
>
> We have some code that's supposed to prevent the PersistenceUntiBuilder from finding a persistence unit in another module, but it doesn't work if the module calling the persistenceUnitBuilder is a war in an ear. For wars, we have to prepend the path to the persistence unit with ../ since the war is a directory not a jar inside the car, and that no longer matches a module path. We can do two resotutions... one against the module path, once against the ../ and check for another module against the module-path-resolved uri.
> This could use some unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3307) persistence units in other
modules should not be picked up by PersistenceUnitDeployer called from a
module
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511669 ]
David Jencks commented on GERONIMO-3307:
----------------------------------------
Fixed AFAICT using daytrader in rev 555182. I'll try to write a unit test shortly.
> persistence units in other modules should not be picked up by PersistenceUnitDeployer called from a module
> ----------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-3307
> URL: https://issues.apache.org/jira/browse/GERONIMO-3307
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: persistence
> Affects Versions: 2.0-M6
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.0-M7
>
>
> We have some code that's supposed to prevent the PersistenceUntiBuilder from finding a persistence unit in another module, but it doesn't work if the module calling the persistenceUnitBuilder is a war in an ear. For wars, we have to prepend the path to the persistence unit with ../ since the war is a directory not a jar inside the car, and that no longer matches a module path. We can do two resotutions... one against the module path, once against the ../ and check for another module against the module-path-resolved uri.
> This could use some unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.