[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1669: Fix deadlock on non response-specific read errors

[GitBox <gi...@apache.org>]

lyndonbauto commented on code in PR #1669:
URL: https://github.com/apache/tinkerpop/pull/1669#discussion_r882892698


##########
gremlin-go/driver/resultSet.go:
##########
@@ -120,6 +121,19 @@ func (channelResultSet *channelResultSet) Close() {
 	}
 }
 
+// Close and remove from the channelResultSet from the container without locking container. Meant for use when calling

Review Comment:
   Is `Close` still used? Overall this LGTM and I think solves this well - just wondering if we can remove the other Close() now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org