You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2024/07/10 05:57:57 UTC
[PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
orpiske opened a new pull request, #14769:
URL: https://github.com/apache/camel/pull/14769
Hey @davsclaus, this is more or less what I was thinking about in my comment on https://github.com/apache/camel/pull/14745#issuecomment-2212350669.
I'm wondering if we should add a log on to inform that we are not calling the `afterConsumeEval.test(null)` because it has not been paused (I have not done so yet, as I think it would flood the log with those messages, because it would be called after every `poll`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219684333
Created https://issues.apache.org/jira/browse/CAMEL-20957 for re-implementing this as a `RoutePolicy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219633886
> BTW, this is just a remedy. Longer term I think I should consider augmenting the `RoutePolicy` API - as you suggested - and checking if this could be moved there in some way.
We can add a note in the kafka doc to point users to route policy as well.
And maybe add an OOTB policy that can use a predicate or something as logic to suspend/resume, so users can use that.
And with the new label=bean configurer we can make it configurable and tooling friendly, and for low-code users as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219652004
Thanks. I'll include these documentation improvements into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219625591
BTW, this is just a remedy. Longer term I think I should consider augmenting the `RoutePolicy` API - as you suggested - and checking if this could be moved there in some way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2220665023
Looking good on the CI. Let's merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219624124
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14769:
URL: https://github.com/apache/camel/pull/14769#issuecomment-2219631386
> Hey @davsclaus, this is more or less what I was thinking about in my comment on [#14745 (comment)](https://github.com/apache/camel/pull/14745#issuecomment-2212350669).
>
> I'm wondering if we should add a log on to inform that we are not calling the `afterConsumeEval.test(null)` because it has not been paused (I have not done so yet, as I think it would flood the log with those messages, because it would be called after every `poll`).
Yeah that is not desireable. If any logging then it can be TRACE level.
Also you can add in javadoc of the API that eval is not called if paused etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #14769:
URL: https://github.com/apache/camel/pull/14769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org