You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Pace2Car (via GitHub)" <gi...@apache.org> on 2023/03/22 11:25:52 UTC
[GitHub] [shardingsphere] Pace2Car opened a new issue, #24756: Improve properties verification of ShardingAlgorithm
Pace2Car opened a new issue, #24756:
URL: https://github.com/apache/shardingsphere/issues/24756
Hi community,
This issue is one of the tasks of #24746.
If not sure what to do, please refer to the example: #24742
## Aim
- [ ] ClassBasedShardingAlgorithm
- [ ] ComplexInlineShardingAlgorithm
- [ ] ClassBasedShardingAlgorithm
- [ ] HintInlineShardingAlgorithm
- [ ] IntervalShardingAlgorithm
- [ ] InlineShardingAlgorithm
- [ ] CosIdSnowflakeIntervalShardingAlgorithm
- [ ] CosIdIntervalShardingAlgorithm
- [ ] CosIdModShardingAlgorithm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1481249421
@liuxiaocs7 OK, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Pace2Car commented on issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1641751682
Since it haven't progressed for too long, I will continue to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuxiaocs7 commented on issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1515202404
Hi, @Pace2Car, thanks for your reminder, I've been a little busy recently so I'm a little behind schedule. At present, the implementation of `ClassBasedShardingAlgorithm` has been completed, could you help me to have a look at it in your free time?
I am not sure whether this modification meets the requirements. My understanding is to enhance the verification rules for the attribute values input in the configuration, and modify the test program accordingly. Does `AlgorithmClassName` need to be further verified by reflection in the `getAlgorithmClassName` method? I see the current logic is in `ClassBasedShardingAlgorithmFactory`.
There are also some other questions. There are many `sharding expressions` and `time format` judgments about the sharding algorithm. Is there any tool class for this part in the project before to check whether it is a valid sharding expression or time format.
I will modify it according to your comments as soon as possible and continue to complete other verifications, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Pace2Car commented on issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1512607538
Hi @liuxiaocs7, a period of time has passed, do you need help with any difficulties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #24756: Improve properties verification of ShardingAlgorithm
URL: https://github.com/apache/shardingsphere/issues/24756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuxiaocs7 commented on issue #24756: Improve properties verification of ShardingAlgorithm
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1481144651
Hi, @RaigorJiang I am a newcomer for shardingsphere, I want to try this issue, please assign to me, thanks! BTW, `ClassBasedSharingAlgorithm` appears twice on the first and third lines.
CC @Pace2Car
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org