You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/14 05:50:33 UTC
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request
#98: Implemented decompression on consumer side
cckellogg commented on a change in pull request #98: Implemented decompression on consumer side
URL: https://github.com/apache/pulsar-client-go/pull/98#discussion_r346136206
##########
File path: pulsar/consumer_partition.go
##########
@@ -220,10 +230,19 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, header
reader := internal.NewMessageReader(headersAndPayload)
msgMeta, err := reader.ReadMessageMetadata()
if err != nil {
- // TODO send discardCorruptedMessage
+ pc.discardCorruptedMessage(pbMsgID, pb.CommandAck_ChecksumMismatch)
return err
}
+ uncompressedHeadersAndPayload, err := pc.Decompress(msgMeta, headersAndPayload)
Review comment:
is there a way to implement this logic in the message reader?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services