You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/09/23 00:08:35 UTC
Review Request 68812: Added example framework for inverse-offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Bugs: MESOS-5827
https://issues.apache.org/jira/browse/MESOS-5827
Repository: mesos
Description
-------
Adds an example framework displaying how to handle inverse offers.
This example is based on the original review request
https://reviews.apache.org/r/50010/ by Joseph Wu.
Some changes were applied adding framework authentication
capabilites, updated PullGauge metrics and other minor adaptations
following the other example frameworks.
Diffs
-----
src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68812/diff/1/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 68812: Added example framework for inverse-offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/#review210100
-----------------------------------------------------------
PASS: Mesos patch 68812 was successfully built and tested.
Reviews applied: `['68812']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2537/mesos-review-68812
- Mesos Reviewbot Windows
On Oct. 26, 2018, 10:20 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68812/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2018, 10:20 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5827
> https://issues.apache.org/jira/browse/MESOS-5827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds an example framework displaying how to handle inverse offers.
> This example is based on the original review request
> https://reviews.apache.org/r/50010/ by Joseph Wu.
> Some changes were applied adding framework authentication
> capabilites, updated PullGauge metrics and other minor adaptations
> following the other example frameworks.
>
>
> Diffs
> -----
>
> src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
> src/examples/CMakeLists.txt a2c0dd12e34ae739be85885fd815514f7d3d59a5
> src/examples/inverse_offer_framework.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68812/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68812: Added example framework for inverse-offers.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/
-----------------------------------------------------------
(Updated Oct. 26, 2018, 5:20 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Ooopsi!
Bugs: MESOS-5827
https://issues.apache.org/jira/browse/MESOS-5827
Repository: mesos
Description
-------
Adds an example framework displaying how to handle inverse offers.
This example is based on the original review request
https://reviews.apache.org/r/50010/ by Joseph Wu.
Some changes were applied adding framework authentication
capabilites, updated PullGauge metrics and other minor adaptations
following the other example frameworks.
Diffs (updated)
-----
src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
src/examples/CMakeLists.txt a2c0dd12e34ae739be85885fd815514f7d3d59a5
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68812/diff/3/
Changes: https://reviews.apache.org/r/68812/diff/2-3/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 68812: Added example framework for inverse-offers.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/
-----------------------------------------------------------
(Updated Oct. 26, 2018, 4:45 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Addressed comments - thanks for the review!
Bugs: MESOS-5827
https://issues.apache.org/jira/browse/MESOS-5827
Repository: mesos
Description
-------
Adds an example framework displaying how to handle inverse offers.
This example is based on the original review request
https://reviews.apache.org/r/50010/ by Joseph Wu.
Some changes were applied adding framework authentication
capabilites, updated PullGauge metrics and other minor adaptations
following the other example frameworks.
Diffs (updated)
-----
src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
src/examples/CMakeLists.txt a2c0dd12e34ae739be85885fd815514f7d3d59a5
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68812/diff/2/
Changes: https://reviews.apache.org/r/68812/diff/1-2/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 68812: Added example framework for inverse-offers.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/#review209970
-----------------------------------------------------------
Fix it, then Ship it!
Please also add it to CMakeLists!
src/examples/inverse_offer_framework.cpp
Lines 495 (patched)
<https://reviews.apache.org/r/68812/#comment294612>
Let's extract it into `constexpr char FRAMEWORK_METRICS_PREFIX[]`.
src/examples/inverse_offer_framework.cpp
Lines 598 (patched)
<https://reviews.apache.org/r/68812/#comment294613>
How about pulling it into a constant, e.g., `constexpr char FRAMEWORK_NAME[]`?
- Alexander Rukletsov
On Sept. 23, 2018, 12:08 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68812/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2018, 12:08 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5827
> https://issues.apache.org/jira/browse/MESOS-5827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds an example framework displaying how to handle inverse offers.
> This example is based on the original review request
> https://reviews.apache.org/r/50010/ by Joseph Wu.
> Some changes were applied adding framework authentication
> capabilites, updated PullGauge metrics and other minor adaptations
> following the other example frameworks.
>
>
> Diffs
> -----
>
> src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
> src/examples/inverse_offer_framework.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68812/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 68812: Added example framework for inverse-offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68812/#review208922
-----------------------------------------------------------
PASS: Mesos patch 68812 was successfully built and tested.
Reviews applied: `['68812']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2382/mesos-review-68812
- Mesos Reviewbot Windows
On Sept. 23, 2018, 12:08 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68812/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2018, 12:08 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5827
> https://issues.apache.org/jira/browse/MESOS-5827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds an example framework displaying how to handle inverse offers.
> This example is based on the original review request
> https://reviews.apache.org/r/50010/ by Joseph Wu.
> Some changes were applied adding framework authentication
> capabilites, updated PullGauge metrics and other minor adaptations
> following the other example frameworks.
>
>
> Diffs
> -----
>
> src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81
> src/examples/inverse_offer_framework.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68812/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>