You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/04/19 20:08:05 UTC
Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233
Repository: geode
Description
-------
GEODE-1233: apply FlakyTest category to Flaky tests
* Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.
Diffs
-----
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
gradle/test.gradle 2dd7521
Diff: https://reviews.apache.org/r/46399/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Kirk Lund <ki...@gmail.com>.
> On April 19, 2016, 6:18 p.m., Anthony Baker wrote:
> > gradle/test.gradle, line 157
> > <https://reviews.apache.org/r/46399/diff/1/?file=1351073#file1351073line157>
> >
> > This excludes 'flaky' tests from the distributedTest task. Does this also apply to integrationTest?
> >
> > How can I run just @FlakyTests?
That will require gradle changes. I've reverted the change I made to test.gradle. My plan was to annotate all flickering test methods with "FlakyTest" first and then later we can make any required changes to test.gradle.
- Kirk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129586
-----------------------------------------------------------
On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:20 p.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
>
>
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1233: apply FlakyTest category to Flaky tests
>
> * Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
> geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
> geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
> geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
> geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
> geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
> geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
>
> Diff: https://reviews.apache.org/r/46399/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129586
-----------------------------------------------------------
gradle/test.gradle (line 157)
<https://reviews.apache.org/r/46399/#comment193019>
This excludes 'flaky' tests from the distributedTest task. Does this also apply to integrationTest?
How can I run just @FlakyTests?
- Anthony Baker
On April 19, 2016, 6:07 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:07 p.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
>
>
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1233: apply FlakyTest category to Flaky tests
>
> * Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
> geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
> geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
> geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
> geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
> geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
> geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
> gradle/test.gradle 2dd7521
>
> Diff: https://reviews.apache.org/r/46399/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129602
-----------------------------------------------------------
Fix it, then Ship it!
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java (lines 197 - 200)
<https://reviews.apache.org/r/46399/#comment193041>
Is this part of GEODE-1233? If it is, then can delete the commented code.
- Mark Bretl
On April 19, 2016, 11:20 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 11:20 a.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
>
>
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1233: apply FlakyTest category to Flaky tests
>
> * Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
> geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
> geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
> geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
> geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
> geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
> geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
>
> Diff: https://reviews.apache.org/r/46399/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129592
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:20 p.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
>
>
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1233: apply FlakyTest category to Flaky tests
>
> * Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
> geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
> geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
> geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
> geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
> geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
> geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
>
> Diff: https://reviews.apache.org/r/46399/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
-----------------------------------------------------------
(Updated April 19, 2016, 8:41 p.m.)
Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
Changes
-------
Removed AvailablePort changes. These changes have been moved to GEODE-1257.
Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233
Repository: geode
Description
-------
GEODE-1233: apply FlakyTest category to Flaky tests
* Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.
Diffs (updated)
-----
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
Diff: https://reviews.apache.org/r/46399/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129594
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:20 p.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
>
>
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1233: apply FlakyTest category to Flaky tests
>
> * Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
>
>
> Diffs
> -----
>
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
> geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
> geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
> geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
> geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
> geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
> geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
> geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
> geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
> geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
> geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
> geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
> geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
> geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
>
> Diff: https://reviews.apache.org/r/46399/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 46399: GEODE-1233: apply FlakyTest category to
flickering tests
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
-----------------------------------------------------------
(Updated April 19, 2016, 6:20 p.m.)
Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William Markito.
Changes
-------
Revert test.gradle change
Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233
Repository: geode
Description
-------
GEODE-1233: apply FlakyTest category to Flaky tests
* Perform basic analysis on all JIRA tickets filed against flickering (intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.
Diffs (updated)
-----
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java 0abd85e
geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 9417d7a
geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java 2acab3a
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java 1250d5a
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java 8f8c966
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java feefb6d
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 8c455d4
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java 5d44dfd
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java c85a6d9
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java 4a4c38d
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java 0853162
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java 677321f
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 8fc8049
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java 6463e88
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java 60fd6ff
geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java ccd9df0
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java 3e5994d
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 639f93f
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java 464b61c
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java 426a8da
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java 27f5e36
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java c9b9ac8
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java 26f0983
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java f6836ae
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java 538132c
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8d6160e
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java 1599271
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java 1da697f
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 64ca3ba
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java a1d6aca
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 8dfe7a5
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 52ebe24
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5eeb04e
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java 710550b
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java 7ab452b
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java e9e7cc1
geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java 2ed0152
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/FixedPRSinglehopDUnitTest.java 358e7ad
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java fa1d2ba
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NetSearchMessagingDUnitTest.java 71a95c5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java ad7b3a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionCreationDUnitTest.java f97bf78
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java c794330
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java 636075c
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SingleHopStatsDUnitTest.java c702d9f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionExecutionDUnitTest.java 8205765
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionNoSingleHopDUnitTest.java cd54be6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java 169ad3a
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/Bug48571DUnitTest.java 09ed9a5
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueDUnitTest.java 7d047c9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java 4245bb6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java ba1ddd2
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionOldConfigDUnitTest.java 3912b90
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java e64759f
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DestroyEntryPropagationDUnitTest.java 67dfbee
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java d92d6e9
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/ReliableMessagingDUnitTest.java 94083f7
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/UpdatePropagationDUnitTest.java ab673a6
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java fbe97bc
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/wan/asyncqueue/AsyncEventListenerOffHeapDUnitTest.java 7feec9a
geode-core/src/test/java/com/gemstone/gemfire/management/DLockManagementDUnitTest.java 5da954f
geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java 5851878
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java 6a761b4
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java b6692c7
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java e8ee713
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 1b0c9cf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java 123c3bc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java f495944
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java 1c6f141
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java 5c159e8
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java f5aa506
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java b625cfa
geode-core/src/test/java/com/gemstone/gemfire/memcached/GemcachedDevelopmentJUnitTest.java 080404f
geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java 3ea5a4e
geode-core/src/test/java/com/gemstone/gemfire/redis/RedisDistDUnitTest.java 825f532
geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthenticationDUnitTest.java 83bf532
geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java 179f29d
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java 724766b
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java 073e82e
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryDUnitTest.java 608c20c
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqQueryUsingPoolDUnitTest.java cd2c12a
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java 8d4477f
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryMonitorDUnitTest.java 3671237
geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientSimpleDUnitTest.java 0a263eb
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java 6fef000
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java fe0e4c3
geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java 5db15f0
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java 9ab6e81
geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java e9a47e2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 7406f2d
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java aca2cb9
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_1_DUnitTest.java 400a289
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_2_DUnitTest.java 6026b3a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANSSLDUnitTest.java f322394
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WanValidationsDUnitTest.java 612a178
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/ParallelWANPropogationOffHeapDUnitTest.java 49afd57
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogationOffHeapDUnitTest.java 1bcb879
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/offheap/SerialWANPropogation_PartitionedRegionOffHeapDUnitTest.java a689eef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderOperationsDUnitTest.java 0d34f44
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPersistenceEnabledGatewaySenderDUnitTest.java ae38110
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANPropagationDUnitTest.java 63a129b
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java 2a5801a
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventListenerDUnitTest.java e7210ef
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropagationLoopBackDUnitTest.java 75d4de2
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java c279d62
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java 66d4279
Diff: https://reviews.apache.org/r/46399/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund