You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 13:59:16 UTC
[PR] fix(metrics): redact data source credentials from config toString [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3373:
URL: https://github.com/apache/rocketmq-dashboard/pull/3373
## Summary
Marks `MetricsDataSourceConfig.password`/`bearerToken` as `@ToString.Exclude` and adds `MetricsDataSourceConfigTest` locking the contract.
Coverage:
- `toString` keeps the non-secret fields (`name`, `url`) while omitting both credential field names and values;
- `@Data` equality/hashCode still cover the credentials, so a rotated token is not equal.
## Why
The raw config model holds credentials that are encrypted only at rest; logs and debug output must not surface them through `toString`.
## Testing
`mvn -B test -Dtest=MetricsDataSourceConfigTest` — 2/2 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): redact data source credentials from config toString [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3373: fix(metrics): redact data source credentials from config toString
URL: https://github.com/apache/rocketmq-dashboard/pull/3373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org