[GitHub] [pinot] walterddr commented on a diff in pull request #9826: [multistage][test] add with statement test

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9826:
URL: https://github.com/apache/pinot/pull/9826#discussion_r1025903603


##########
pinot-query-runtime/src/test/resources/queries/WithStatements.json:
##########
@@ -0,0 +1,81 @@
+{
+  "with_statement_tests": {
+    "psql": "7.8.1",
+    "tables": {
+      "tbl1": {
+        "schema": [
+          {"name": "strCol", "type": "STRING"},

Review Comment:
   could you be more specific?
   
   - `select .. from (With as x ( select from tbl))` is not a valid syntax.
   - `with (...) AS a, with (...) AS b SELECT (...) FROM ` is already added. did you meant you would like to nest the previously with tbl in another WITH? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org