[GitHub] [pinot] abhioncbr commented on a diff in pull request #10545: [feature] [null support # 4] Support null in some default transform functions

["abhioncbr (via GitHub)" <gi...@apache.org>]

abhioncbr commented on code in PR #10545:
URL: https://github.com/apache/pinot/pull/10545#discussion_r1157901520


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LogicalOperatorTransformFunction.java:
##########
@@ -44,7 +46,8 @@ public void init(List<TransformFunction> arguments, Map<String, ColumnContext> c
     }
     for (int i = 0; i < numArguments; i++) {
       TransformResultMetadata argumentMetadata = arguments.get(i).getResultMetadata();
-      if (!(argumentMetadata.isSingleValue() && argumentMetadata.getDataType().getStoredType().isNumeric())) {
+      FieldSpec.DataType storedType = argumentMetadata.getDataType().getStoredType();

Review Comment:
   The minor thing should follow the same style as in [.../java/org/apache/pinot/core/operator/transform/function/NotOperatorTransformFunction.java](https://github.com/apache/pinot/pull/10545/files#diff-6c199b55bb366622c5b0d017f9f02cb3641e6ac5476f03c547d231bb38f0be24) condition check. I think the `Preconditions.checkState` usage is neat.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org